Denis Kirillov dkirillov
0 followers · 0 following
  • Joined on 2023-03-06
Repositories
19
 Projects Packages Code Public activity Starred repositories
1
dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#130 2023-06-15 08:59:32 +00:00
[#135] Support GSet for credentials

I considered this but decided that having separate command leads to refactoring (due to code duplication) and this refactor tends to be quite comprehensive #131

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#126 2023-06-14 12:20:37 +00:00
Add chunk uploading

which is set when X-Amz-Algorithm != AWS4-HMAC-SHA256

Actually, we don't use client time when we get request with presigned url. But I wouldn't say that it be more error prone if we set…

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#136 2023-06-14 11:48:16 +00:00
[#111] Use request scope logger

No

dkirillov approved TrueCloudLab/frostfs-http-gw#60 2023-06-14 11:45:30 +00:00
Use gRPC interceptor from observability package
dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#126 2023-06-14 10:54:27 +00:00
Add chunk uploading

Shouldn't we also check the content-encoding for containing aws-chunked?

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#126 2023-06-14 10:52:44 +00:00
Add chunk uploading

Actually this test doesn't check signature.

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#126 2023-06-14 10:48:28 +00:00
Add chunk uploading

Why don't we check the err here?

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#126 2023-06-14 09:49:21 +00:00
Add chunk uploading

To check this we can use for example test:

func TestPutObjectWithStreamBodyError(t *testing.T) {
	tc := prepareHandlerContext(t)

	bktName, objName := "bucket-for-put", "object-for-p…
dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#126 2023-06-14 09:34:19 +00:00
Add chunk uploading

After h.logAndSendError we must use return statement

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#126 2023-06-14 09:33:28 +00:00
Add chunk uploading

Let's move this to separate function

dkirillov approved TrueCloudLab/frostfs-s3-gw#140 2023-06-14 09:20:53 +00:00
Use gRPC interceptor from observability package
dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#140 2023-06-14 09:18:47 +00:00
Use gRPC interceptor from observability package

This will be overriden on line 337

dkirillov pushed to feature/103-handle_timeout_errors at dkirillov/frostfs-s3-gw 2023-06-14 06:16:34 +00:00
462589fc0c [#103] Return 504 http code on timeout errors
8fcaf76f41 [#132] authmate: Add bearer token to obtain-secret result
Compare 2 commits »
8470e0d8e4 [#111] Use request scope logger
8fcaf76f41 [#132] authmate: Add bearer token to obtain-secret result
Compare 2 commits »
73e3a55424 [#111] Use request scope logger
19c89b38e6 [#133] Update docs
0bcda6ea37 [#133] Drop sync-tree
9dabaf6ecd [#133] Use tree pool from SDK
Compare 4 commits »
dkirillov pushed to feature/103-handle_timeout_errors at dkirillov/frostfs-s3-gw 2023-06-13 15:05:36 +00:00
722df824c5 [#103] Return 504 http code on timeout errors
19c89b38e6 [#133] Update docs
0bcda6ea37 [#133] Drop sync-tree
9dabaf6ecd [#133] Use tree pool from SDK
Compare 4 commits »
dkirillov created pull request TrueCloudLab/frostfs-s3-gw#138 2023-06-13 14:55:17 +00:00
[#103] Return 504 http code on timeout errors
dkirillov pushed to feature/103-handle_timeout_errors at dkirillov/frostfs-s3-gw 2023-06-13 14:54:52 +00:00
9bf64a2151 [#103] Return 504 http code on timeout errors
dkirillov created branch feature/103-handle_timeout_errors in dkirillov/frostfs-s3-gw 2023-06-13 14:47:42 +00:00
dkirillov pushed to feature/103-handle_timeout_errors at dkirillov/frostfs-s3-gw 2023-06-13 14:47:42 +00:00
73b49966a0 [#103] Return 504 http code on timeout errors