Denis Kirillov

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527

2024-11-21 09:45:30 +00:00

[#469] List multipart uploads streaming

It seems we can simplify this to

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527

2024-11-21 09:42:26 +00:00

[#469] List multipart uploads streaming

Why do we treat this error special? It seems normally we traverse node in right order and if we don't see parent it's a bug in storage node. Root node filepath we can set initially to this map

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527

2024-11-21 09:29:22 +00:00

[#469] List multipart uploads streaming

Why not just fileName, ok := tNode.FileName() ?

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527

2024-11-21 09:28:19 +00:00

[#469] List multipart uploads streaming

Do we really need new variable err2?

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527

2024-11-21 09:25:01 +00:00

[#469] List multipart uploads streaming

I would use errors.Is(err, io.EOF)

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527

2024-11-21 09:23:05 +00:00

[#469] List multipart uploads streaming

This function should be

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527

2024-11-21 09:20:02 +00:00

[#469] List multipart uploads streaming

Please, use the similar check a12fea8a5b/pkg/service/tree/tree.go (L987)

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527

2024-11-21 09:17:24 +00:00

[#469] List multipart uploads streaming

I suppose we should check if tNode.IsSplit() and skip if necessary. And only after that use tNode.ID[0]

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527

2024-11-21 08:26:19 +00:00

[#469] List multipart uploads streaming

I'm not sure if it's ok to separate this invocation. At least as it's done now.

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527

2024-11-21 08:06:50 +00:00

[#469] List multipart uploads streaming

Please mention these params in https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/branch/master/config/config.yaml and https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/branch/master/con…

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527

2024-11-21 08:01:03 +00:00

[#469] List multipart uploads streaming

Then we should fix streaming in tree, because we it must return only nodes that have provided prefix. (/my in this case, and object /zzz/object/name3 doesn't have such prefix )

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#557

2024-11-21 06:57:57 +00:00

[#502] Add Dropped logs (by sampling) metric

Please, use approach as for UsersAPIStats or APIStatMetrics or StateMetrics