Denis Kirillov dkirillov
0 followers · 0 following
  • Joined on 2023-03-06
Repositories
18
 Projects Packages Code Public activity Starred repositories
1
dkirillov commented on pull request TrueCloudLab/frostfs-dev-env#87 2024-10-29 13:51:20 +00:00
[#85] Add s3 lifecycler

This param should be in frostfs section see https://git.frostfs.info/TrueCloudLab/frostfs-s3-lifecycler/src/branch/master/docs/configuration.md

dkirillov commented on pull request TrueCloudLab/frostfs-dev-env#87 2024-10-29 13:51:05 +00:00
[#85] Add s3 lifecycler

This param should be in frostfs section see https://git.frostfs.info/TrueCloudLab/frostfs-s3-lifecycler/src/branch/master/docs/configuration.md

dkirillov commented on pull request TrueCloudLab/frostfs-dev-env#87 2024-10-29 13:48:08 +00:00
[#85] Add s3 lifecycler

The same for .int_test.env

dkirillov commented on pull request TrueCloudLab/frostfs-dev-env#87 2024-10-29 13:46:23 +00:00
[#85] Add s3 lifecycler

This file should be link (see example in s3_gate/.env or any other dir)

dkirillov commented on pull request TrueCloudLab/frostfs-dev-env#87 2024-10-29 13:43:32 +00:00
[#85] Add s3 lifecycler

It seems this file should be

dkirillov commented on pull request TrueCloudLab/frostfs-dev-env#87 2024-10-29 13:39:29 +00:00
[#85] Add s3 lifecycler

Why don't we use version 0.1.3 ? https://hub.docker.com/r/truecloudlab/frostfs-s3-lifecycler/tags

dkirillov commented on pull request TrueCloudLab/frostfs-contract#119 2024-10-28 14:27:50 +00:00
Integrate frostfsid into NNS

It seems we can write just

dkirillov approved TrueCloudLab/frostfs-node#1443 2024-10-28 14:25:40 +00:00
tree: Use delete verb instead put for Remove
dkirillov approved TrueCloudLab/frostfs-s3-gw#521 2024-10-28 13:47:42 +00:00
Multinet dialer support

LGTM

dkirillov approved TrueCloudLab/frostfs-s3-gw#525 2024-10-28 09:04:30 +00:00
feature/501-add_trace_id_to_logs_of_erroneous_requests_at_middleware
dkirillov commented on pull request TrueCloudLab/frostfs-http-gw#153 2024-10-28 08:34:38 +00:00
[#151] Index page for FrostFS containers

Please, rebase branch

dkirillov commented on pull request TrueCloudLab/frostfs-http-gw#153 2024-10-28 08:33:55 +00:00
[#151] Index page for FrostFS containers

I meant something like

diff --git a/internal/handler/browse.go b/internal/handler/browse.go
index a2373d1..b55d349 100644
--- a/internal/handler/browse.go
+++ b/internal/handler/browse…
dkirillov commented on pull request TrueCloudLab/frostfs-http-gw#153 2024-10-28 08:15:46 +00:00
[#151] Index page for FrostFS containers

Here we also should add wg.Done

dkirillov commented on pull request TrueCloudLab/frostfs-http-gw#153 2024-10-28 08:15:17 +00:00
[#151] Index page for FrostFS containers

This 4 lines seems confusing to me.

dkirillov commented on pull request TrueCloudLab/frostfs-sdk-go#290 2024-10-28 07:31:37 +00:00
[#185] Control timeout of tree service operations

Oh, I see. Ok

dkirillov commented on pull request TrueCloudLab/frostfs-http-gw#153 2024-10-28 06:51:03 +00:00
[#151] Index page for FrostFS containers

Pool size should be configurable. And default should be at least 100 (maybe 1000)

dkirillov commented on pull request TrueCloudLab/frostfs-http-gw#153 2024-10-28 06:44:52 +00:00
[#151] Index page for FrostFS containers

Please, don't use fatal. Otherwise by sighup server can be stopped

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#525 2024-10-25 14:16:28 +00:00
feature/501-add_trace_id_to_logs_of_erroneous_requests_at_middleware

Ideally, I would also like to display the trace id in the request start log. However, I…

dkirillov approved TrueCloudLab/frostfs-s3-gw#525 2024-10-25 14:12:36 +00:00
feature/501-add_trace_id_to_logs_of_erroneous_requests_at_middleware

LGTM

dkirillov commented on pull request TrueCloudLab/frostfs-contract#119 2024-10-25 13:59:58 +00:00
Integrate frostfsid into NNS

New method should also be added to frsotfsid/client/client.go file