Herman Slatman
c40a4d2694
Contain policy engines inside provisioner Controller
2022-04-22 01:20:38 +02:00
Herman Slatman
ef110a94df
Change pointer booleans to regular boolean configuration
2022-04-21 23:45:05 +02:00
Herman Slatman
e9f5a1eb98
Improve policy bad request handling
2022-04-21 17:16:02 +02:00
Herman Slatman
b72430f4ea
Block all APIs when using linked deployment mode
2022-04-21 16:18:55 +02:00
Herman Slatman
fb81407d6f
Fix ACME policy comments
2022-04-21 13:21:06 +02:00
Herman Slatman
a2cfbe3d54
Fix (part of) PR comments
2022-04-21 12:14:03 +02:00
Herman Slatman
3eecc4f7bb
Improve test coverage for reloadPolicyEngines
2022-04-19 17:10:13 +02:00
Herman Slatman
72bbe53376
Add additional policy options
2022-04-19 14:41:36 +02:00
Herman Slatman
9a21208f22
Add deduplication of policy configuration values
2022-04-19 13:21:37 +02:00
Herman Slatman
f2f9cb899e
Add conditional defaults to policy protobuf request bodies
2022-04-19 12:09:45 +02:00
Herman Slatman
647538e9e8
Merge branch 'herman/allow-deny' into herman/allow-deny-options
2022-04-19 10:32:16 +02:00
Herman Slatman
ad2de16299
Merge branch 'master' into herman/allow-deny
2022-04-19 10:26:31 +02:00
Herman Slatman
7f9034d22a
Add additional policy options
2022-04-19 10:24:52 +02:00
Mariano Cano
fe9c3cf753
Merge branch 'master' into ahmet2mir-feat/vault
2022-04-18 15:35:26 -07:00
Herman Slatman
def9438ad6
Improve handling of bad JSON protobuf bodies
2022-04-18 23:38:13 +02:00
Herman Slatman
2ca5c0170f
Fix flaky test behavior for protobuf messages
2022-04-18 22:39:47 +02:00
Herman Slatman
abcad679ff
Merge branch 'master' into herman/allow-deny
2022-04-18 21:54:55 +02:00
Herman Slatman
8d15a027a7
Fix if-else linting issue
2022-04-18 21:47:13 +02:00
Mariano Cano
c066694c0c
Allow renew token issuer to be the provisioner name.
...
For consistency with AuthorizeAdminToken, AuthorizeRenewToken will
allow the issuer to be either the fixed string 'step-ca-client/1.0'
or the provisioner name.
2022-04-18 12:38:09 -07:00
Herman Slatman
99702d3648
Fix case of no authority policy existing
2022-04-18 21:14:30 +02:00
Herman Slatman
d6be9450be
Merge branch 'master' into herman/allow-deny
2022-04-15 11:57:05 +02:00
Herman Slatman
30d5d89a13
Improve test coverage for Policy Admin API
2022-04-15 10:43:25 +02:00
Mariano Cano
d3b6bc3c75
Merge branch 'master' into fix/adminra
2022-04-13 17:44:23 -07:00
Mariano Cano
ad5aedfa60
Fix backward compatibility in AuthorizeAdminToken
...
This commit validates both new and old issuers.
2022-04-13 16:00:15 -07:00
Mariano Cano
5f714f2485
Fix tests for AuthorizeRenewToken
2022-04-13 15:59:37 -07:00
Mariano Cano
674dc3c844
Rename unreleased claim to allowRenewalAfterExpiry for consistency.
2022-04-13 15:11:54 -07:00
Mariano Cano
4e4d4e882f
Use a fixed string for renewal token issuer.
2022-04-13 14:50:06 -07:00
Mariano Cano
0a5dc237df
Fix typo in comment.
2022-04-12 17:56:39 -07:00
Mariano Cano
00cd0f5f21
Apply suggestions from code review
...
Co-authored-by: Herman Slatman <hslatman@users.noreply.github.com>
2022-04-12 14:44:55 -07:00
Mariano Cano
ea5f7f2acc
Fix SANs for step-ca certificate
...
Co-authored-by: Herman Slatman <hslatman@users.noreply.github.com>
2022-04-12 13:57:55 -07:00
Mariano Cano
37b521ec6c
Merge branch 'master' into feat/vault
2022-04-11 14:57:45 -07:00
Mariano Cano
c8c59d68f5
Allow mTLS renewals if the provisioner extension does not exists.
...
This fixes a backward compatibility issue with with the new
LoadProvisionerByCertificate.
2022-04-11 12:19:42 -07:00
Herman Slatman
256fe113f7
Improve tests for ACME account policy
2022-04-11 15:25:55 +02:00
Panagiotis Siatras
f2cf9cf828
authority/status: removed the package ( #892 )
2022-04-11 11:56:16 +03:00
Mariano Cano
af8fcf5b01
Use always LoadProvisionerByCertificate on authority package
2022-04-08 14:18:24 -07:00
Mariano Cano
1d1e095447
Add tests for LoadProvisionerByCertificate.
2022-04-08 13:06:29 -07:00
Herman Slatman
0bb15e16f9
Fix missing ACME provisioner option
2022-04-08 16:10:26 +02:00
Herman Slatman
9797b3350e
Merge branch 'master' into herman/allow-deny
2022-04-08 16:01:56 +02:00
Mariano Cano
dfdc9c06ed
Fix linter error importShadow
2022-04-07 18:33:13 -07:00
Mariano Cano
8abd568f03
Merge branch 'master' into fix/adminra
2022-04-07 18:25:41 -07:00
Mariano Cano
b7e11da480
Merge branch 'master' into feat/linkedra
2022-04-07 18:19:04 -07:00
Mariano Cano
c55b27a2fc
Refactor admin token to use with RAs.
2022-04-07 18:14:43 -07:00
Herman Slatman
034b7943fe
Merge branch 'master' into herman/allow-deny
2022-04-07 14:12:20 +02:00
Herman Slatman
7df52dbb76
Add ACME EAB policy
2022-04-07 14:11:53 +02:00
Mariano Cano
db337debcd
Load provisioner from the database instead of the extension.
2022-04-05 19:25:47 -07:00
Mariano Cano
df8ffb35af
Remove unnecessary database in provisioner config.
2022-04-05 17:39:06 -07:00
Carl Tashian
150eee70df
Updates based on Herman's feedback
2022-04-05 10:59:25 -07:00
Carl Tashian
4b9f44982d
Merge branch 'master' into startup-info
2022-04-04 12:19:55 -07:00
Carl Tashian
43f2c655b9
More info on startup
2022-04-04 12:16:37 -07:00
Herman Slatman
679e2945f2
Disallow name constraint wildcard notation
2022-04-04 15:35:49 +02:00
Herman Slatman
96f4c49b0c
Improve how policy errors are returned and used
2022-04-04 13:58:16 +02:00
Herman Slatman
d8776d8f7f
Add K8sSA SSH user policy back
...
According to the docs, the K8sSA provisioner can be configured
to issue SSH user certs.
2022-04-01 15:37:48 +02:00
Herman Slatman
571b21abbc
Fix (most) PR comments
2022-03-31 16:12:29 +02:00
Carl Tashian
1ba1584c7a
Formatted.
2022-03-30 16:08:10 -07:00
Carl Tashian
a13e58e340
Update GetAuthorityInfo -> GetInfo
2022-03-30 16:07:16 -07:00
Carl Tashian
90cb6315b1
Progress.
2022-03-30 16:05:26 -07:00
Carl Tashian
055e75f394
Progress?
2022-03-30 15:48:42 -07:00
Herman Slatman
bfa4d809fd
Improve middleware test coverage
2022-03-30 18:21:25 +02:00
Herman Slatman
6da243c34d
Add policy precheck for all admins
2022-03-30 15:39:03 +02:00
Herman Slatman
628d7448de
Don't return policy in provisioner JSON
2022-03-30 15:20:38 +02:00
Herman Slatman
2fbdf7d5b0
Merge branch 'master' into herman/allow-deny
2022-03-30 14:50:14 +02:00
Herman Slatman
0e052fe299
Add authority policy API
2022-03-30 14:21:39 +02:00
Panagiotis Siatras
00634fb648
api/render, api/log: initial implementation of the packages ( #860 )
...
* api/render: initial implementation of the package
* acme/api: refactored to support api/render
* authority/admin: refactored to support api/render
* ca: refactored to support api/render
* api: refactored to support api/render
* api/render: implemented Error
* api: refactored to support api/render.Error
* acme/api: refactored to support api/render.Error
* authority/admin: refactored to support api/render.Error
* ca: refactored to support api/render.Error
* ca: fixed broken tests
* api/render, api/log: moved error logging to this package
* acme: refactored Error so that it implements render.RenderableError
* authority/admin: refactored Error so that it implements render.RenderableError
* api/render: implemented RenderableError
* api/render: added test coverage for Error
* api/render: implemented statusCodeFromError
* api: refactored RootsPEM to work with render.Error
* acme, authority/admin: fixed pointer receiver name for consistency
* api/render, errs: moved StatusCoder & StackTracer to the render package
2022-03-30 11:22:22 +03:00
Mariano Cano
955d4cf80d
Add authority.WithX509SignerFunc
...
This change adds a new authority option that allows to pass a callback
that returns the certificate chain and signer used to sign X.509
certificates.
This option will be used by Caddy, they renew the intermediate
certificate weekly and there's no other way to replace it without
re-creating the embedded CA.
Fixes #874
2022-03-28 17:54:35 -07:00
Mariano Cano
6851842841
Fix unit tests.
2022-03-28 15:06:56 -07:00
Mariano Cano
580a9c1476
Get linked RA configuration using the linked ca client.
2022-03-28 14:55:40 -07:00
vijayjt
37207793f9
Pass in the resource name regardless of if its a VM or managed identity
2022-03-28 14:55:40 -07:00
vijayjt
7e47c70af2
Remove redundant parameter type declaration
2022-03-28 14:55:40 -07:00
vijayjt
7b605b2d16
Support Azure tokens from managed identities not associated with a VM
2022-03-28 14:55:39 -07:00
Mariano Cano
5ab79f53be
Fix linter errors
2022-03-28 14:55:39 -07:00
Herman Slatman
b49307f326
Fix ACME order tests with mock ACME CA
2022-03-24 18:34:04 +01:00
Herman Slatman
9e0edc7b50
Add early authority policy evaluation to ACME order API
2022-03-24 14:55:40 +01:00
Herman Slatman
613c99f00f
Fix linting issues
2022-03-24 13:10:49 +01:00
Herman Slatman
dc23fd23bf
Merge branch 'master' into herman/allow-deny-next
2022-03-24 12:36:12 +01:00
Herman Slatman
6b620c8e9c
Improve protobuf unmarshaling error handling
2022-03-24 10:54:45 +01:00
Mariano Cano
082734474b
Merge pull request #845 from vijayjt/azure-user-mi-token
...
WIP: Support Azure tokens generated by managed identities
2022-03-23 17:18:51 -07:00
Carl Tashian
25cc9a1728
Update authority/authority.go
...
Co-authored-by: Herman Slatman <hslatman@users.noreply.github.com>
2022-03-22 07:38:09 -07:00
Mariano Cano
9d027c17d0
Send current provisioner on PostCertificate
2022-03-21 19:24:05 -07:00
Mariano Cano
b401376829
Add current provisioner to AuthorizeSign SignOptions.
...
The original provisioner cannot be retrieved from a certificate
if a linked ra is used.
2022-03-21 19:21:40 -07:00
vijayjt
24a963766e
Pass in the resource name regardless of if its a VM or managed identity
2022-03-22 00:10:43 +00:00
Carl Tashian
baf3c40fef
Print some basic configuration info on startup
2022-03-21 16:55:09 -07:00
Mariano Cano
ad8a813abe
Fix linter errors
2022-03-21 16:53:57 -07:00
Herman Slatman
101ca6a2d3
Check admin subjects before changing policy
2022-03-21 15:53:59 +01:00
Panagiotis Siatras
4fb38afc57
authority/admin/api: refactored to use the read package
2022-03-18 20:21:00 +02:00
Herman Slatman
81b0c6c37c
Add API implementation for authority and provisioner policy
2022-03-15 15:56:04 +01:00
Mariano Cano
6d532045dc
Fix validity check for sshpop provisioner.
2022-03-14 17:31:21 -07:00
Mariano Cano
c903f00cd4
Rename claim to allowRenewAfterExpiry.
2022-03-14 15:40:01 -07:00
Mariano Cano
4690fa64ed
Add public methods to retrieve the provisioner extensions.
2022-03-11 14:59:42 -08:00
Mariano Cano
616490a9c6
Refactor renew after expiry token authorization
...
This changes adds a new authority method that authorizes the
renew after expiry tokens.
2022-03-10 20:21:01 -08:00
Mariano Cano
79349b4d7c
Add options to use custom renewal methods.
2022-03-10 13:01:08 -08:00
Mariano Cano
389815642d
Fix tests: certs are truncated to seconds.
2022-03-10 10:46:28 -08:00
Mariano Cano
8ef8f4f665
Use the provisioner controller in Nebula renewals
2022-03-10 10:45:12 -08:00
Mariano Cano
259e95947c
Add support for the provisioner controller
...
The claimer, audiences and custom callback methods are now managed
by the provisioner controller in an uniform way.
2022-03-09 18:43:45 -08:00
Mariano Cano
3c2ff33ca9
Add provisioner controller tests.
2022-03-09 18:43:27 -08:00
Mariano Cano
fd6a2eeb9c
Add provisioner controller
...
The provisioner controller has the implementation of the identity
function as well as the renew methods with renew after expiry
support.
2022-03-09 18:39:09 -08:00
Herman Slatman
3ec9a7310c
Fix ACME order identifier allow/deny check
2022-03-08 14:17:59 +01:00
Herman Slatman
7c541888ad
Refactor configuration of allow/deny on authority level
2022-03-08 13:26:07 +01:00
Herman Slatman
af53a17bb4
Merge branch 'master' into herman/allow-deny
2022-03-07 14:13:13 +01:00
vijayjt
4822516d72
Remove redundant parameter type declaration
2022-03-07 12:07:48 +00:00
vijayjt
e699244291
Support Azure tokens from managed identities not associated with a VM
2022-03-07 11:24:58 +00:00
Mariano Cano
15b1049f19
Fix json tag for Azure.ObjectIDs.
2022-02-28 14:36:37 -08:00
Mariano Cano
6f46cdb432
Merge pull request #829 from vijayjt/new-azure-token-authz-options
...
Add subscription and object ID validation options to Azure provisioner
2022-02-28 14:31:28 -08:00
max furman
a79d4af19b
change return value of generateProvisionerConfig to value
...
- always used as value (rather than pointer)
2022-02-28 11:04:40 -08:00
max furman
6030f8bc2e
Validate provisioner configuration before storing in DB
2022-02-28 10:48:01 -08:00
vijayjt
b128e37090
Add SubscriptionIDs and ObjectIDs to provisioner-linkedca conversion functions
2022-02-25 11:06:48 +00:00
vijayjt
4a10f2c584
Rename new fields as per feedback to remove AAD from the name
2022-02-24 09:26:45 +00:00
vijayjt
8b68bedffa
Add support for validation of certificate requests using Azure subscription and AAD object IDs. See #735
2022-02-22 17:20:18 +00:00
Herman Slatman
c3c6f3da72
Merge branch 'master' into herman/allow-deny
2022-02-22 17:36:56 +01:00
Mariano Cano
abe951d416
Fix name of the variable in comment.
2022-02-17 17:59:17 -08:00
Mariano Cano
a0cf808393
Make the X5C leaf certificate available to the templates.
...
X509 and SSH templates of the X5C provisioner will have now access
to the leaf certificate used to sign the token using the template
variable .AuthorizationCrt
Fixes #433
2022-02-17 17:53:44 -08:00
Mariano Cano
c0525381eb
Merge branch 'master' into feat/vault
2022-02-16 18:19:23 -08:00
Herman Slatman
4ebf43c011
Merge pull request #820 from smallstep/herman/acme-api
...
Refactor ACME Admin API
2022-02-10 13:11:44 +01:00
Herman Slatman
5b713a564c
Change CM link
2022-02-10 12:55:47 +01:00
Herman Slatman
5cb23c6029
Merge pull request #804 from smallstep/herman/normalize-ipv6-dns-names
...
Normalize IPv6 hostname addresses
2022-02-09 11:25:24 +01:00
Herman Slatman
d00729df0b
Refactor ACME Admin API
2022-02-08 13:26:30 +01:00
max furman
62690ab52e
Fix linting errors and pin linter version in release action
2022-02-03 12:23:02 -08:00
Mariano Cano
d384b534c7
Merge pull request #814 from smallstep/x509-enforcer
...
Authority enforcer option
2022-02-03 10:53:04 -08:00
Herman Slatman
bfa2245abb
Merge branch 'master' into herman/normalize-ipv6-dns-names
2022-02-03 17:24:08 +01:00
Herman Slatman
e887ccaa07
Ensure the CA TLS certificate represents IPv6 DNS names as IP in cert
...
If an IPv6 domain name (i.e. [::1]) is provided manually in the `ca.json`,
this commit will ensure that it's represented as an IP SAN in the TLS
certificate. Before this change, the IPv6 would become a DNS SAN.
2022-02-03 14:21:23 +01:00
Mariano Cano
300c19f8b9
Add a custom enforcer that can be used to modify a cert.
2022-02-02 14:36:58 -08:00
Herman Slatman
88c7b63c9d
Split SSH user and cert policy configuration and execution
2022-02-01 15:18:39 +01:00
Herman Slatman
acd13cb92d
Merge branch 'master' of github.com:smallstep/certificates into herman/allow-deny
2022-01-31 14:43:46 +01:00
Herman Slatman
c1424036bf
Merge branch 'master' into herman/allow-deny
2022-01-31 14:24:34 +01:00
Herman Slatman
c7c5c3c94e
Merge branch 'master' into herman/scep-macos-renewal-fixes
2022-01-31 13:20:16 +01:00
Herman Slatman
9617edf0c2
Improve internationalized domain name handling
...
This PR improves internationalized domain name handling according
to rules of IDNA and based on the description in RFC 5280, section 7:
https://datatracker.ietf.org/doc/html/rfc5280#section-7 .
Support for internationalized URI(s), so-called IRIs, still needs to
be done.
2022-01-27 17:18:33 +01:00
Herman Slatman
512b8d6730
Refactor instantiation of policy engines
...
Instead of using the `base` struct, the x509 and SSH policy
engines are now added to each provisioner directly.
2022-01-25 16:45:25 +01:00
Herman Slatman
066bf32086
Fix part of PR comments
2022-01-25 15:00:07 +01:00
Herman Slatman
fd9845e9c7
Add cursor and limit to ACME EAB DB interface
2022-01-24 14:03:56 +01:00
Herman Slatman
3b72d241e0
Add LinkedCA integration for improved SCEP provisioner
2022-01-21 16:07:50 +01:00
Herman Slatman
868cc4ad7f
Increase test coverage for additional indexes
2022-01-20 17:06:23 +01:00
Herman Slatman
8838961b68
Merge branch 'master' into hs/acme-eab
2022-01-20 11:05:28 +01:00
Herman Slatman
716b946e7a
Normalize IPv6 hostname addresses
2022-01-19 17:14:45 +01:00
Herman Slatman
64680bb16d
Fix PR comments
2022-01-19 11:31:33 +01:00
Herman Slatman
3612eefc31
Cleanup
2022-01-18 15:54:18 +01:00
Herman Slatman
6440870a80
Clean up, improve test cases and coverage
2022-01-18 14:39:21 +01:00
Herman Slatman
1e808b61e5
Merge logic for X509 and SSH policy
2022-01-17 23:36:13 +01:00
Herman Slatman
6bc301339f
Improve test case and code coverage
2022-01-17 22:55:28 +01:00
Herman Slatman
91d51c2b88
Add allow/deny to Nebula provisioner
2022-01-14 13:06:32 +01:00
Herman Slatman
d9c56d67cc
Merge branch 'master' into herman/allow-deny
2022-01-14 12:58:07 +01:00
Herman Slatman
9c6580ccd2
Fix macOS SCEP client issues
...
Fixes #746
2022-01-14 10:48:23 +01:00
Ahmet DEMIR
68b980d689
feat(authority): avoid hardcoded cn in authority csr
2022-01-13 20:30:54 +01:00
Herman Slatman
988efc8cd4
Merge pull request #792 from smallstep/herman/improve-template-errors
...
Improve errors related to template execution failures
2022-01-12 21:38:51 +01:00
Herman Slatman
50c3bce98d
Change if/if to if/else-if when checking the type of JSON error
2022-01-12 21:34:38 +01:00
max furman
4afcdd55ff
Update doc line on WithSSHGetHosts
2022-01-12 12:25:04 -08:00
Herman Slatman
a3cf6bac36
Add special handling for *json.UnmarshalTypeError
2022-01-12 11:15:39 +01:00
Herman Slatman
0475a4d26f
Refactor extraction of JSON template syntax errors
2022-01-12 10:41:36 +01:00
Herman Slatman
a5455d3572
Improve errors related to template execution failures (slightly)
2022-01-10 15:49:37 +01:00
Mariano Cano
de549adf2d
Do not add extra new lines when creating nebula provisioners
2022-01-07 11:24:59 -08:00
Mariano Cano
0920224816
Fix error message.
2022-01-07 11:09:32 -08:00
Herman Slatman
ef16febf40
Refactor ACME EAB queries
...
The ACME EAB keys are now also indexed by the provisioner. This
solves part of the issue in which too many EAB keys may be in
memory at a given time.
2022-01-07 16:59:55 +01:00
