Update gRPC dependency #1268
Labels
No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-node#1268
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
DialContext
is now deprecated0231b0d942/clientconn.go (L221)
It uses
NewClient
internally, we should move to it too.We have one important case, which needs to continue to work:
We need it to properly work during failover: if the host is down, we would like to wait for a small timeout, not for a big one.
Operation timeout is comparable to the client timeout, so the scenario above somewhat prevents client errors.
As can be seen from the
DialContext
source,WaitForStateChange
may be of help.In this task, also check api-go and SDK, we might want to create a generic helper somewhere.
However, this is an antipattern (
WithBlock
, see https://github.com/grpc/grpc-go/blob/master/Documentation/anti-patterns.md), so another solution to failover cases may be possible.Another appproach to failover cases:
Currently this "some time" is constant. The suggestion is to create a background thread, waiting for a state change. New RPC can then be sent to that thread. It seems this way we can handle "node is permanently offline" situation well.
Closed via #1374