rpc: Accept interface in place of ClientConn #98

Merged

fyrchik merged 1 commit from fyrchik/frostfs-api-go:clientconn-interface into master

2024-08-01 11:49:46 +00:00

fyrchik commented

2024-07-31 12:38:38 +00:00

Owner

gRPC client load-balancing API is ugly as f:

It is configured by pre-registering a balancer and the providing JSON
configuration.
It doesn't allow different credentials for different endpoints
(consider using "insecure" localhost and external endpoint).
To support frostfs usecase we also need to implement a resolver,
which has its own difficulties.
https://github.com/grpc/grpc-go/issues/239#issuecomment-264548415

Using interface in place of grpc.ClientConn allows us to provide custom
implentation for it (load-balancing, circuit breaker etc.).

Refs TrueCloudLab/frostfs-node#1268

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

gRPC client load-balancing API is ugly as f: 1. It is configured by pre-registering a balancer and the providing JSON configuration. 2. It doesn't allow different credentials for different endpoints (consider using "insecure" localhost and external endpoint). 3. To support frostfs usecase we also need to implement a resolver, which has its own difficulties. 4. https://github.com/grpc/grpc-go/issues/239#issuecomment-264548415 Using interface in place of grpc.ClientConn allows us to provide custom implentation for it (load-balancing, circuit breaker etc.). Refs TrueCloudLab/frostfs-node#1268 Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

fyrchik added 1 commit 2024-07-31 12:38:41 +00:00

rpc: Accept interface in place of ClientConn

DCO action / DCO (pull_request) Failing after 1m17s

Details

Tests and linters / Tests (1.19) (pull_request) Successful in 1m38s

Details

Tests and linters / Tests (1.20) (pull_request) Successful in 1m59s

Details

Tests and linters / Tests with -race (pull_request) Successful in 2m3s

Details

Tests and linters / Lint (pull_request) Successful in 2m25s

Details

ed0a12b8bb

gRPC client load-balancing API is ugly as f:
1. It is configured by pre-registering a balancer and the providing JSON
   configuration.
2. It doesn't allow different credentials for different endpoints
   (consider using "insecure" localhost and external endpoint).
3. To support frostfs usecase we also need to implement a resolver,
   which has its own difficulties.
4. https://github.com/grpc/grpc-go/issues/239#issuecomment-264548415

Using interface in place of grpc.ClientConn allows us to provide custom
implentation for it (load-balancing, circuit breaker etc.).

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

fyrchik force-pushed clientconn-interface from ed0a12b8bb to e092ce4cf8

2024-07-31 12:38:54 +00:00

Compare