TrueCloudLab/frostfs-contract
22
0
Fork 19
Code Issues 12 Pull requests 1 Projects Releases 2 Activity Actions

Reapply "[#53] proxy: Allow using proxy by trusted accounts" #62

Merged
fyrchik merged 1 commit from fyrchik/frostfs-contract:fix-proxy into master 2023-12-18 07:13:49 +00:00
Conversation 3 Commits 1 Files changed 3 +102 -14
fyrchik commented 2023-12-15 11:16:56 +00:00
Owner
Copy link

It was reverted because Verify with arguments was not well supported
by the client software. Thanks to recent System.Runtime.CurrentSigners
call from neo-go v0.104.0 we can take the best of both worlds.

Verify with argument still looks better (less overhead), but this
implementation should work too. Sadly, overloads are not of much use
here because verification routines take the first method from the
manifest, albeit with arbitrary number of arguments.

This reverts commit a0b73150c6.

It was reverted because `Verify` with arguments was not well supported by the client software. Thanks to recent `System.Runtime.CurrentSigners` call from neo-go v0.104.0 we can take the best of both worlds. Verify with argument still looks better (less overhead), but this implementation should work too. Sadly, `overloads` are not of much use here because verification routines take the _first_ method from the manifest, albeit with arbitrary number of arguments. This reverts commit a0b73150c6ae2fe4b108d9e2b434904f4a66e5b3.
fyrchik commented 2023-12-15 11:17:43 +00:00
Author
Owner
Copy link

Actually, this is the implementation I wanted to do initially, which is now possible thanks to CurrentSigners syscall. Made me very happy for some reason.

Actually, this is the implementation I wanted to do initially, which is now possible thanks to `CurrentSigners` syscall. Made me very happy for some reason.
fyrchik force-pushed fix-proxy from e9af866386 to 8e574ebf60 2023-12-15 11:17:59 +00:00 Compare
fyrchik requested review from storage-core-committers 2023-12-15 11:18:05 +00:00
fyrchik requested review from storage-core-developers 2023-12-15 11:18:14 +00:00
fyrchik requested review from storage-services-committers 2023-12-15 11:18:15 +00:00
fyrchik requested review from storage-services-developers 2023-12-15 11:18:16 +00:00
fyrchik force-pushed fix-proxy from 8e574ebf60 to 01faa35dd6 2023-12-15 11:21:43 +00:00 Compare
fyrchik force-pushed fix-proxy from 01faa35dd6 to 5d7887412a 2023-12-15 11:24:01 +00:00 Compare
fyrchik force-pushed fix-proxy from 5d7887412a to 98fec367d6 2023-12-15 11:27:27 +00:00 Compare
fyrchik force-pushed fix-proxy from 98fec367d6 to 734c87c5d7 2023-12-15 11:28:24 +00:00 Compare
fyrchik force-pushed fix-proxy from 734c87c5d7 to e3d3b2947e 2023-12-15 11:31:34 +00:00 Compare
fyrchik force-pushed fix-proxy from e3d3b2947e to fe07f43092 2023-12-15 11:32:27 +00:00 Compare
fyrchik force-pushed fix-proxy from fe07f43092 to 23e85d11c4 2023-12-15 11:34:34 +00:00 Compare
acid-ant approved these changes 2023-12-15 12:03:26 +00:00
aarifullin approved these changes 2023-12-15 12:12:15 +00:00
dkirillov approved these changes 2023-12-15 12:53:26 +00:00
fyrchik added the
blocked
 label 2023-12-15 13:39:51 +00:00
fyrchik commented 2023-12-15 13:40:28 +00:00
Author
Owner
Copy link

Blocked until we update neo-go in the internal build/test infrastructure, eta 3 days.

Blocked until we update neo-go in the internal build/test infrastructure, eta 3 days.
fyrchik removed the
blocked
 label 2023-12-15 14:14:13 +00:00
alexvanin approved these changes 2023-12-18 07:12:58 +00:00
fyrchik merged commit 23e85d11c4 into master 2023-12-18 07:13:49 +00:00
fyrchik deleted branch fix-proxy 2023-12-18 07:13:49 +00:00
alexvanin commented 2023-12-18 07:18:09 +00:00
Owner
Copy link

@fyrchik Last time we had some issues with deployment in dev-env. What should we change in config?

@fyrchik Last time we had some issues with deployment in dev-env. What should we change in config?
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
aarifullin
dkirillov
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-contract#62
No description provided.
Delete branch "fyrchik/frostfs-contract:fix-proxy"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?