TrueCloudLab/frostfs-dev-env
39
0
Fork 17
Code Issues 17 Pull requests 1 Releases Activity Actions

Add support for the -q flag in healthcheck #72

Merged
fyrchik merged 2 commits from achuprov/frostfs-dev-env:feat/quiet_flag into master 2024-08-19 06:25:05 +00:00
Conversation 4 Commits 2 Files changed 4 +5 -21
achuprov commented 2024-07-08 07:41:26 +00:00
Member
Copy link

Close #69

Close #69
achuprov force-pushed feat/quiet_flag from edca4c4b13 to aff7428583 2024-07-08 07:45:13 +00:00 Compare
achuprov requested review from storage-core-committers 2024-07-08 07:45:38 +00:00
achuprov requested review from storage-core-developers 2024-07-08 07:45:39 +00:00
achuprov force-pushed feat/quiet_flag from aff7428583 to 26cff52d80 2024-07-08 07:52:03 +00:00 Compare
fyrchik commented 2024-07-31 08:20:42 +00:00
Owner
Copy link

@achuprov why is it WIP?

@achuprov why is it WIP?
achuprov commented 2024-07-31 09:08:18 +00:00
Author
Member
Copy link

@fyrchik
I incorrectly used the WIP prefix; it should have been tagged as blocked.

This PR is waiting for the stable release of frostfs-node 0.42.X. Do we consider 0.42.3 stable enough to update the version?

@fyrchik I incorrectly used the `WIP` prefix; it should have been tagged as `blocked`. This PR is waiting for the stable release of frostfs-node `0.42.X`. Do we consider `0.42.3` stable enough to update the version?
achuprov added the
blocked
 label 2024-07-31 09:09:20 +00:00
achuprov changed title from WIP: Add support for the -q flag in `healthcheck` to Add support for the -q flag in `healthcheck` 2024-07-31 09:09:26 +00:00
fyrchik commented 2024-08-06 12:41:08 +00:00
Owner
Copy link

@achuprov v0.42.6 is ok

@achuprov v0.42.6 is ok
acid-ant reviewed 2024-08-06 13:22:34 +00:00
services/ir/docker-compose.yml Outdated
@ -26,3 +25,3 @@
command: [ "frostfs-ir", "--config", "/etc/frostfs/ir/config.yml" ]
healthcheck:
test: ["CMD-SHELL", "/healthcheck.sh"]
test: ["CMD-SHELL", "/frostfs-cli control ir healthcheck --wallet /wallet01.key --endpoint \"$$FROSTFS_IR_CONTROL_GRPC_ENDPOINT\""]
acid-ant commented 2024-08-06 13:22:34 +00:00
Member
Copy link

Should we use -q option here too?

Should we use `-q` option here too?
achuprov commented 2024-08-17 03:27:59 +00:00
Author
Member
Copy link

Thx, fixed

Thx, fixed
achuprov force-pushed feat/quiet_flag from 26cff52d80 to 4f9c9df021 2024-08-17 03:25:44 +00:00 Compare
achuprov commented 2024-08-17 03:29:21 +00:00
Author
Member
Copy link

Tested with #76

Tested with https://git.frostfs.info/TrueCloudLab/frostfs-dev-env/pulls/76
achuprov removed the
blocked
 label 2024-08-17 03:29:36 +00:00
fyrchik approved these changes 2024-08-19 06:18:06 +00:00
dstepanov-yadro approved these changes 2024-08-19 06:21:52 +00:00
fyrchik merged commit ae658469a5 into master 2024-08-19 06:25:05 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
dstepanov-yadro
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-dev-env#72
No description provided.
Delete branch "achuprov/frostfs-dev-env:feat/quiet_flag"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?