TrueCloudLab/frostfs-dev-env
41
0
Fork 17
Code Issues 14 Pull requests 1 Releases Activity Actions

Add volume for morph_chain #70

Merged
fyrchik merged 2 commits from achuprov/frostfs-dev-env:feat/morph_chain_volume into master 2024-08-19 11:54:58 +00:00
Conversation 3 Commits 2 Files changed 3 +11 -3
achuprov commented 2024-06-28 11:05:49 +00:00
Member
Copy link

Close #68

$ frostfs-cli --config /home/achuprov/Documents/work/frostfs-dev-env/wallets/conf.yml netmap epoch
3

make down up

$ frostfs-cli --config /home/achuprov/Documents/work/frostfs-dev-env/wallets/conf.yml netmap epoch
4

make down clean up 

$ frostfs-cli --config /home/achuprov/Documents/work/frostfs-dev-env/wallets/conf.yml netmap epoch
1

Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Close #68 ``` $ frostfs-cli --config /home/achuprov/Documents/work/frostfs-dev-env/wallets/conf.yml netmap epoch 3 ``` ``` make down up ``` ``` $ frostfs-cli --config /home/achuprov/Documents/work/frostfs-dev-env/wallets/conf.yml netmap epoch 4 ``` ``` make down clean up ``` ``` $ frostfs-cli --config /home/achuprov/Documents/work/frostfs-dev-env/wallets/conf.yml netmap epoch 1 ``` Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov force-pushed feat/morph_chain_volume from 701c1aa176 to 7837919a49 2024-06-28 11:06:59 +00:00 Compare
achuprov requested review from storage-core-committers 2024-06-28 11:08:03 +00:00
achuprov requested review from storage-core-developers 2024-06-28 11:08:08 +00:00
acid-ant reviewed 2024-06-28 11:47:16 +00:00
Makefile Outdated
@ -84,3 +77,1 @@
echo "Transfer GAS to wallet $${f}" \
&& ./vendor/frostfs-adm -c frostfs-adm.yml morph refill-gas --storage-wallet $${f} --gas 10.0 \
|| die "Failed to transfer GAS to alphabet wallets"; \
@if ! ./vendor/frostfs-adm morph dump-hashes --config frostfs-adm.yml > /dev/null 2>&1; then
acid-ant commented 2024-06-28 11:47:16 +00:00
Member
Copy link

How about to check for presence and exit if exists?
Diff will be shorter in this case.

How about to check for presence and `exit` if exists? Diff will be shorter in this case.
fyrchik commented 2024-06-28 13:30:20 +00:00
Owner
Copy link

dump-hashes is not a reliable check, because we could kill adm deploy before e.g. all NNS aliases are set.
init should be idempotent, if it is not, then it is a separate bug.

`dump-hashes` is not a reliable check, because we could kill adm deploy before e.g. all NNS aliases are set. `init` should be idempotent, if it is not, then it is a separate bug.
fyrchik commented 2024-06-28 13:30:40 +00:00
Owner
Copy link

What error do you get if you execute init twice?

What error do you get if you execute `init` twice?
fyrchik commented 2024-06-28 13:30:40 +00:00
Owner
Copy link

What error do you get if you execute init twice?

What error do you get if you execute `init` twice?
achuprov commented 2024-07-10 13:54:23 +00:00
Author
Member
Copy link

You are right, this check is not needed. The error that occurs when calling init again is: Error: can't create transfer transaction: script failed (FAULT state) due to an error: at instruction 280 (ASSERT): ASSERT failed

You are right, this check is not needed. The error that occurs when calling init again is: `Error: can't create transfer transaction: script failed (FAULT state) due to an error: at instruction 280 (ASSERT): ASSERT failed`
achuprov marked this conversation as resolved
achuprov changed title from Add volume for morph_chain to WIP: Add volume for morph_chain 2024-07-10 13:54:32 +00:00
fyrchik commented 2024-07-31 08:21:19 +00:00
Owner
Copy link

@achuprov why is it WIP?

@achuprov why is it WIP?
achuprov commented 2024-07-31 09:08:47 +00:00
Author
Member
Copy link

@achuprov why is it WIP?

See #72 (comment)

> @achuprov why is it WIP? See https://git.frostfs.info/TrueCloudLab/frostfs-dev-env/pulls/72#issuecomment-45698
achuprov changed title from WIP: Add volume for morph_chain to Add volume for morph_chain 2024-07-31 09:09:51 +00:00
achuprov added the
blocked
 label 2024-07-31 09:09:57 +00:00
achuprov force-pushed feat/morph_chain_volume from 7837919a49 to c6c5346870 2024-08-17 05:09:19 +00:00 Compare
achuprov commented 2024-08-17 05:10:23 +00:00
Author
Member
Copy link

Tested with #76

Tested with #76
achuprov removed the
blocked
 label 2024-08-17 05:10:32 +00:00
fyrchik approved these changes 2024-08-19 11:23:40 +00:00
dstepanov-yadro approved these changes 2024-08-19 11:25:08 +00:00
fyrchik merged commit dd382f8ce0 into master 2024-08-19 11:54:58 +00:00
elebedeva approved these changes 2024-08-19 11:57:04 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
dstepanov-yadro
elebedeva
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-dev-env#70
No description provided.
Delete branch "achuprov/frostfs-dev-env:feat/morph_chain_volume"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?