adm/morph: Fix transfer GAS to alphabet nodes #1239

achuprov · 2024-07-10T21:00:53Z

achuprov commented

2024-07-10 21:00:53 +00:00

Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Ref # https://git.frostfs.info/TrueCloudLab/frostfs-dev-env/pulls/70 ![1](/attachments/b34d93a5-11ad-4418-8fb8-072574c06e69) ![2](/attachments/3ea2e4c5-4ff8-4837-90b9-235591258cf1) Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>

1.png

16 KiB

2.png

11 KiB

achuprov requested review from storage-core-committers 2024-07-10 21:08:34 +00:00

achuprov requested review from storage-core-developers 2024-07-10 21:08:40 +00:00

fyrchik reviewed 2024-07-11 07:28:17 +00:00

cmd/frostfs-adm/internal/modules/morph/initialize/initialize_transfer.go Outdated

					
				@ -81,3 +81,3 @@

					r := nep17.NewReader(c.ReadOnlyInvoker, gas.Hash)

					res, err := r.BalanceOf(acc.Contract.ScriptHash())

					return res.Cmp(big.NewInt(initialAlphabetGASAmount/2)) == 1, err

					return res.Cmp(big.NewInt(5*native.GASFactor)) == 1, err

fyrchik commented

2024-07-11 07:28:11 +00:00

It doesn't depend on the number of alphabet nodes (is that what we want?), how about initialAlphabetGASAmount / 100500?
Anyway, where does 5 comes from?

It doesn't depend on the number of alphabet nodes (is that what we want?), how about `initialAlphabetGASAmount / 100500`? Anyway, where does `5` comes from?

achuprov commented

2024-07-11 10:31:36 +00:00

The initialAlphabetGASAmount is set as initialAlphabetGASAmount = 10_000 * native.GASFactor and does not depend on the number of alphabet nodes.
The coefficient of 5 was obtained empirically.

The `initialAlphabetGASAmount` is set as `initialAlphabetGASAmount = 10_000 * native.GASFactor` and does not depend on the number of alphabet nodes. The coefficient of `5` was obtained empirically.

👍 1

fyrchik commented

2024-07-11 14:05:04 +00:00

Please, move 5 to a constant with a comment about why it is as it is.

👍 1