TrueCloudLab/frostfs-http-gw
13
0
Fork 16
Code Issues 10 Pull requests 3 Projects Releases 7 Activity Actions

[#22] Update system attributes #22

Merged
alexvanin merged 1 commit from dkirillov/frostfs-http-gw:feature/update_system_attributes into master 2023-07-26 21:07:55 +00:00
Conversation 0 Commits 1 Files changed 1 +10
dkirillov commented 2023-03-22 06:21:13 +00:00
Member
Copy link
No description provided.
dkirillov self-assigned this 2023-03-22 06:21:13 +00:00
dkirillov changed title from WIP: feature/update_system_attributes to WIP: [#22] Update system attributes 2023-03-22 06:21:42 +00:00
dkirillov force-pushed feature/update_system_attributes from a047da7207 to 7c769638a0 2023-03-22 06:22:31 +00:00 Compare
dkirillov force-pushed feature/update_system_attributes from 7c769638a0 to 8d81913674 2023-03-22 06:42:43 +00:00 Compare
dkirillov changed title from WIP: [#22] Update system attributes to [#22] Update system attributes 2023-03-22 07:46:16 +00:00
dkirillov requested review from anikeev-yadro 2023-03-22 07:46:31 +00:00
dkirillov requested review from storage-services-committers 2023-03-22 07:46:31 +00:00
dkirillov requested review from storage-services-developers 2023-03-22 07:46:31 +00:00
anikeev-yadro approved these changes 2023-03-22 08:03:26 +00:00
alexvanin reviewed 2023-03-22 08:54:15 +00:00
README.md Outdated
@ -445,2 +442,2 @@
3. `X-Attribute-Neofs-Expiration-Timestamp: 1637574797`
4. `X-Attribute-Neofs-Expiration-RFC3339: 2021-11-22T09:55:49Z`
There are some reserved headers type of `X-Attribute-SYSTEM-*` (headers are arranged in descending order of priority):
1. `X-Attribute-Frostfs-Expiration-Epoch: 100`
alexvanin commented 2023-03-22 08:54:15 +00:00
Owner
Copy link

Should be system and not frostfs?

Should be `system` and not `frostfs?`
👍 1
alexvanin marked this conversation as resolved
dkirillov force-pushed feature/update_system_attributes from 8d81913674 to c0284c2505 2023-03-22 08:57:51 +00:00 Compare
alexvanin reviewed 2023-03-22 08:59:07 +00:00
uploader/filter.go Outdated
@ -14,3 +14,3 @@
)
var frostfsAttributeHeaderPrefixes = [...][]byte{[]byte("Neofs-"), []byte("NEOFS-"), []byte("neofs-")}
var frostfsAttributeHeaderPrefixes = [...][]byte{[]byte("System-"), []byte("SYSTEM-"), []byte("system-")}
alexvanin commented 2023-03-22 08:58:54 +00:00
Owner
Copy link

Do we want to keep compatibility with deprecated prefixes for couple of releases?

/cc @TrueCloudLab/storage-services-committers

Do we want to keep compatibility with deprecated prefixes for couple of releases? /cc @TrueCloudLab/storage-services-committers
alexvanin commented 2023-03-23 13:44:25 +00:00
Owner
Copy link

After TrueCloudLab/frostfs-s3-gw#67 and TrueCloudLab/frostfs-sdk-go#40 I think we have to support compatibility there for a couple releases.

/cc @dkirillov

After https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/issues/67 and https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/issues/40 I think we have to support compatibility there for a couple releases. /cc @dkirillov
👍 1
alexvanin marked this conversation as resolved
dkirillov force-pushed feature/update_system_attributes from c0284c2505 to 296f3d3c66 2023-03-22 11:50:07 +00:00 Compare
anikeev-yadro approved these changes 2023-03-22 12:35:57 +00:00
dkirillov force-pushed feature/update_system_attributes from 296f3d3c66 to 5ad6738de9 2023-03-24 07:48:45 +00:00 Compare
dkirillov force-pushed feature/update_system_attributes from 5ad6738de9 to c10a34ea87 2023-03-24 07:59:36 +00:00 Compare
dkirillov force-pushed feature/update_system_attributes from c10a34ea87 to 8dc3e88276 2023-03-24 08:00:23 +00:00 Compare
dkirillov force-pushed feature/update_system_attributes from 8dc3e88276 to 9fd705ef41 2023-03-24 08:15:41 +00:00 Compare
dkirillov force-pushed feature/update_system_attributes from 9fd705ef41 to 399eab9671 2023-03-24 08:17:12 +00:00 Compare
alexvanin reviewed 2023-03-24 08:27:59 +00:00
README.md Outdated
@ -447,2 +446,3 @@
4. `X-Attribute-System-Expiration-RFC3339: 2021-11-22T09:55:49Z`
which transforms to `X-Attribute-Neofs-Expiration-Epoch`. So you can provide expiration any convenient way.
which transforms to `X-Attribute-Frostfs-Expiration-Epoch`. So you can provide expiration any convenient way.
alexvanin commented 2023-03-24 08:19:00 +00:00
Owner
Copy link

transforms to X-Attribute-System-Expiration-Epoch

transforms to `X-Attribute-System-Expiration-Epoch`
👀 1
alexvanin marked this conversation as resolved
integration_test.go Outdated
@ -409,2 +410,3 @@
domain.SetName(testContainerName)
container.WriteDomain(&cnr, domain)
// currently in aio node know nothing about new sys attributes
alexvanin commented 2023-03-24 08:24:35 +00:00
Owner
Copy link

Maybe todo and link with #2?

Maybe todo and link with #2?
👍 1
alexvanin marked this conversation as resolved
uploader/upload.go Outdated
@ -120,28 +113,20 @@ func (u *Uploader) Upload(c *fasthttp.RequestCtx) {
response.Error(c, err.Error(), fasthttp.StatusBadRequest)
return
}
if needParseExpiration(filtered) {
alexvanin commented 2023-03-24 08:27:42 +00:00
Owner
Copy link

This check is basically moved into PrepareExpirationHeader, right?

This check is basically moved into `PrepareExpirationHeader`, right?
dkirillov commented 2023-03-24 08:29:07 +00:00
Author
Member
Copy link

Yes

Yes
alexvanin marked this conversation as resolved
dkirillov force-pushed feature/update_system_attributes from 399eab9671 to 81f7168a16 2023-03-24 08:34:09 +00:00 Compare
alexvanin approved these changes 2023-03-24 08:36:04 +00:00
alexvanin merged commit 81f7168a16 into master 2023-03-24 08:36:43 +00:00
alexvanin deleted branch feature/update_system_attributes 2023-03-24 08:36:43 +00:00
alexvanin referenced this pull request from a commit 2023-03-24 08:36:44 +00:00
[#22] Update CHANGELOG.md
alexvanin added this to the v0.27.0 milestone 2023-07-12 08:13:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
anikeev-yadro
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.27.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-http-gw#22
No description provided.
Delete branch "dkirillov/frostfs-http-gw:feature/update_system_attributes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?