TrueCloudLab/frostfs-node
18
1
Fork 27
Code Issues 93 Pull requests 3 Projects Releases 1 Activity Actions

[#159] Add handle __SYSTEM__ sys attributes #159

Merged
fyrchik merged 1 commit from dkirillov/frostfs-node:feature/add_frostfs_system_attribute into master 2023-03-23 08:10:22 +00:00
Conversation 0 Commits 1 Files changed 10 +40 -26
dkirillov commented 2023-03-22 06:45:29 +00:00
Member
Copy link

Related to TrueCloudLab/frostfs-http-gw#22

Related to https://git.frostfs.info/TrueCloudLab/frostfs-http-gw/pulls/22
dkirillov changed title from WIP: [#XX] Add handle __SYSTEM__ sys attributes to WIP: [#159] Add handle __SYSTEM__ sys attributes 2023-03-22 06:45:38 +00:00
dkirillov force-pushed feature/add_frostfs_system_attribute from d8f5a139bc to b198584b73 2023-03-22 06:46:17 +00:00 Compare
dkirillov force-pushed feature/add_frostfs_system_attribute from b198584b73 to 567d8475e9 2023-03-22 06:46:30 +00:00 Compare
dkirillov changed title from WIP: [#159] Add handle __SYSTEM__ sys attributes to [#159] Add handle __SYSTEM__ sys attributes 2023-03-22 07:44:48 +00:00
dkirillov requested review from storage-core-developers 2023-03-22 07:44:54 +00:00
dkirillov requested review from storage-core-committers 2023-03-22 07:44:54 +00:00
dkirillov requested review from alexvanin 2023-03-22 07:46:04 +00:00
fyrchik reviewed 2023-03-22 08:26:54 +00:00
CHANGELOG.md Outdated
@ -69,6 +70,8 @@ You need to change configuration environment variables to `FROSTFS_*` if you use
New config field `object.delete.tombstone_lifetime` allows to set tombstone lifetime
more appropriate for a specific deployment.
Use `__SYSTEM__` prefix for system attributes instead of `__NEOFS__`.
fyrchik commented 2023-03-22 08:22:34 +00:00
Owner
Copy link

Not obvious whether __NEOFS__ is still supported.

Not obvious whether `__NEOFS__` is still supported.
pkg/local_object_storage/metabase/exists.go Outdated
@ -111,3 +111,3 @@
// expired previously for less than the one epoch duration
var expired bool
expired := isExpiredWithAttribute(tx, objectV2.SysAttributeExpEpoch, addr, currEpoch)
fyrchik commented 2023-03-22 08:26:33 +00:00
Owner
Copy link

Can we do this only if the bucket does not exist? If it exists, we should not bother checking the second.
Also, we should validate in service that only 1 of the prefixes is used.

Can we do this only if _the bucket_ does not exist? If it exists, we should not bother checking the second. Also, we should validate in service that only 1 of the prefixes is used.
pkg/local_object_storage/metabase/iterators.go
@ -60,7 +60,10 @@ func (db *DB) iterateExpired(tx *bbolt.Tx, epoch uint64, h ExpiredObjectHandler)
err := tx.ForEach(func(name []byte, b *bbolt.Bucket) error {
cidBytes := cidFromAttributeBucket(name, objectV2.SysAttributeExpEpoch)
fyrchik commented 2023-03-22 08:23:24 +00:00
Owner
Copy link

Can we try having 1 bucket on the metabase level? I think translation could be done on an upper level.

Can we try having 1 bucket on the metabase level? I think translation could be done on an upper level.
fyrchik commented 2023-03-22 11:25:33 +00:00
Owner
Copy link

Okay, it can make our code more complex without many benefits. Let's postpone this discussion.

Okay, it can make our code more complex without many benefits. Let's postpone this discussion.
fyrchik marked this conversation as resolved
dkirillov force-pushed feature/add_frostfs_system_attribute from 567d8475e9 to 841d5a8add 2023-03-22 11:55:49 +00:00 Compare
dkirillov force-pushed feature/add_frostfs_system_attribute from 841d5a8add to 342e571d89 2023-03-22 14:35:43 +00:00 Compare
fyrchik approved these changes 2023-03-23 06:04:46 +00:00
acid-ant approved these changes 2023-03-23 08:04:03 +00:00
fyrchik merged commit 342e571d89 into master 2023-03-23 08:10:22 +00:00
dkirillov deleted branch feature/add_frostfs_system_attribute 2023-03-23 12:23:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
fyrchik
acid-ant
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#159
No description provided.
Delete branch "dkirillov/frostfs-node:feature/add_frostfs_system_attribute"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?