TrueCloudLab/frostfs-node

`make gopls-run` fails with go1.24 #1671

New issue

Closed

opened 2025-03-13 05:53:42 +00:00 by fyrchik · 3 comments

fyrchik commented

2025-03-13 05:53:42 +00:00

Owner

# golang.org/x/telemetry/crashmonitor
/home/dzeta/go/pkg/mod/golang.org/x/telemetry@v0.0.0-20240209200032-7b892fcb8a78/crashmonitor/crash_go123.go:13:19: cannot use debug.SetCrashOutput (value of type func(f *os.File, opts debug.CrashOptions) error) as func(*os.File) error value in assignment

``` # golang.org/x/telemetry/crashmonitor /home/dzeta/go/pkg/mod/golang.org/x/telemetry@v0.0.0-20240209200032-7b892fcb8a78/crashmonitor/crash_go123.go:13:19: cannot use debug.SetCrashOutput (value of type func(f *os.File, opts debug.CrashOptions) error) as func(*os.File) error value in assignment ```

fyrchik added the

labels 2025-03-13 05:53:42 +00:00

fyrchik self-assigned this 2025-03-13 05:53:51 +00:00

fyrchik referenced this issue

2025-03-13 07:05:02 +00:00

Fix future gopls issues #1672

fyrchik commented

2025-03-13 07:06:18 +00:00

Author

Owner

Investigate if we can somehow ignore code blocks.
modernize have false positives, but I still want to have it enabled for other stuff.

Investigate if we can somehow ignore code blocks. `modernize` have false positives, but I still want to have it enabled for other stuff.

fyrchik commented

2025-03-13 07:06:49 +00:00

Author

Owner

Update to 0.18 fixes this error, but introduces linter warnings.

Update to 0.18 fixes this error, but introduces linter warnings.

fyrchik referenced this issue

2025-03-13 07:11:32 +00:00

Investigate logger gopls issues #1673

fyrchik added the

label 2025-03-13 07:41:22 +00:00

fyrchik referenced this issue from a commit

2025-03-13 08:12:23 +00:00

[#1671] Replace `interface{}` with `any`

fyrchik referenced this issue from a commit

2025-03-13 08:12:23 +00:00

[#1671] Use max builtin where possible

fyrchik referenced this issue from a commit

2025-03-13 08:12:23 +00:00

[#1671] Use `fmt.Appendf` where warranted

fyrchik referenced this issue from a commit

2025-03-13 08:12:23 +00:00

[#1671] Use `min` builtin where possible

fyrchik referenced this issue from a commit

2025-03-13 08:12:23 +00:00

[#1671] Use `slices.Delete()` where possible

fyrchik referenced this issue from a commit

2025-03-13 08:12:24 +00:00

[#1671] Use `slices.ContainsFunc()` where possible

fyrchik referenced this issue from a pull request that will close it,

2025-03-14 13:46:06 +00:00

Update go to 1.23, update tools #1680

fyrchik commented

2025-03-14 13:46:51 +00:00

Author

Owner

Update to 0.17.1 seems to fix the issue.
0.18 introduces modernize linter which is yet to be discussed.

Update to 0.17.1 seems to fix the issue. 0.18 introduces `modernize` linter which is yet to be discussed.

fyrchik closed this issue

2025-03-17 10:02:56 +00:00

fyrchik referenced this issue from a commit

2025-03-17 10:02:57 +00:00

[#1671] Update gopls to v0.17.1

Sign in to join this conversation.

No labels

good first issue

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1671

No description provided.