Fix future gopls issues #1672
Labels
No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No project
No assignees
5 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-node#1672
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "fyrchik/frostfs-node:update-gopls"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Updated to gopls 0.18.1, fixed most of the issues.
Some issues are still here, though:
range over int
: explicitly ignored with a comment in #1345.slices.ContainsFunc
: we have functions likeIterate(func(..) bool)
. While we can currently useContainsFunc
for this, it feels wrong, because we do not use the return value.unused write
: need investigation, #1673Refs #1671
interface{}
withany
8fb1fcf684fmt.Appendf
where warranted 0cb0aacaefmin
builtin where possible 29b0240673slices.Delete()
where possible 803a550c1fslices.ContainsFunc()
where possible