TrueCloudLab/frostfs-node

Investigate logger gopls issues #1673

New issue

Closed

opened 2025-03-13 07:04:00 +00:00 by fyrchik · 1 comment

fyrchik commented

2025-03-13 07:04:00 +00:00

Owner

There are some unused writes.
Sampling field looks similar.

pkg/util/logger/logger.go:150:4: unused write to field Level
pkg/util/logger/logger.go:151:4: unused write to field Encoding

Check that everything works as expected and also explain WHY that code was there.

There are some unused writes. `Sampling` field looks similar. ``` pkg/util/logger/logger.go:150:4: unused write to field Level pkg/util/logger/logger.go:151:4: unused write to field Encoding ``` Check that everything works as expected and also explain WHY that code was there.

fyrchik added the

labels 2025-03-13 07:04:00 +00:00

fyrchik referenced this issue

2025-03-13 07:04:35 +00:00

Fix future gopls issues #1672

fyrchik commented

2025-03-13 07:11:32 +00:00

Author

Owner

After this task we can update gopls to v0.17.1 and fix #1671.

After this task we can update `gopls` to `v0.17.1` and fix #1671.

dstepanov-yadro was assigned by fyrchik

2025-03-13 07:11:38 +00:00

fyrchik added this to the v0.45.0 milestone 2025-03-13 07:12:46 +00:00

fyrchik added the

label 2025-03-13 07:41:24 +00:00

dstepanov-yadro referenced this issue from a pull request that will close it,

2025-03-13 08:43:44 +00:00

Fix journald logger #1674

dstepanov-yadro referenced this issue from a commit

2025-03-13 12:14:25 +00:00

[#1673] logger: Drop unused fields

dstepanov-yadro referenced this issue from a commit

2025-03-13 12:14:25 +00:00

[#1673] logger: Add sampling for journald logger

dstepanov-yadro closed this issue

2025-03-13 12:14:29 +00:00

Sign in to join this conversation.

No labels

good first issue

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1673

No description provided.