Fix >23 nodes multitransfer in frostfs-adm #352

New issue

Closed

opened 2023-05-15 13:05:37 +00:00 by fyrchik · 1 comment

fyrchik commented

2023-05-15 13:05:37 +00:00

Owner

We have 1024 byte limit on a tx witness invocation script.
740488f7f3/pkg/core/transaction/witness.go (L10)
Committee of >23 nodes effectively can't sign anything. (signature is 64 byte, we have 16 signatures needed, 16 * 64 = 1024).

I am not sure we can simply fix this, though.
Let's at least document the behaviour first:

Frostfs-adm documentation
Alphabet letters definitions in code.

We have 1024 byte limit on a tx witness invocation script. https://github.com/nspcc-dev/neo-go/blob/740488f7f35e367eaa99a71c0a609c315fe2b0fc/pkg/core/transaction/witness.go#L10 Committee of >23 nodes effectively _can't_ sign anything. (signature is 64 byte, we have 16 signatures needed, 16 * 64 = 1024). I am not sure we can simply fix this, though. Let's at least document the behaviour first: 1. Frostfs-adm documentation 2. Alphabet letters definitions in code.

fyrchik added the

labels 2023-05-15 13:05:37 +00:00

ale64bit referenced this issue

2023-05-16 08:24:05 +00:00

[#352] Add explicit max number of alphabet nodes #354

fyrchik referenced this issue from a commit

2023-05-17 15:01:28 +00:00

[#352] Add explicit max number of alphabet nodes

fyrchik removed the

bug

label 2023-05-18 08:20:07 +00:00

fyrchik added this to the vNext milestone 2023-05-18 08:31:03 +00:00

fyrchik added the

internal

label 2024-05-16 10:45:03 +00:00

fyrchik commented

2024-05-16 12:21:46 +00:00

Author

Owner

It seems the doc is already here

// MaxAlphabetNodes is the maximum number of candidates allowed, which is currently limited by the size

It seems the doc is already here https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/af57d5a6a12f1be58c836e079ff3fc73acca39b3/cmd/frostfs-adm/internal/modules/morph/constants/const.go#L9

fyrchik closed this issue

2024-05-16 12:21:48 +00:00

fyrchik modified the milestone from vNext to v0.40.0

2024-05-16 12:21:52 +00:00

fyrchik referenced this issue

2024-06-26 08:34:58 +00:00

adm: Refactor `helper` in part of reading alphabet wallets #1203