TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

[#352] Add explicit max number of alphabet nodes #354

Merged
fyrchik merged 1 commit from ale64bit/frostfs-node:fix/352-clarify-too-many-alpha-nodes into master 2023-05-17 15:01:28 +00:00
Conversation 0 Commits 1 Files changed 4 +41 -10
ale64bit commented 2023-05-16 08:24:05 +00:00
Member
Copy link

Signed-off-by: Alejandro Lopez a.lopez@yadro.com

Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>
ale64bit requested review from storage-core-committers 2023-05-16 08:24:21 +00:00
ale64bit requested review from storage-core-developers 2023-05-16 08:24:22 +00:00
acid-ant approved these changes 2023-05-16 08:32:57 +00:00
fyrchik reviewed 2023-05-16 12:42:52 +00:00
cmd/frostfs-adm/internal/modules/morph/initialize.go Outdated
@ -26,0 +26,4 @@
const (
// maxAlphabetNodes is the maximum number of candidates allowed, which is currently limited by the size
// of the verification script.
// See: https://github.com/nspcc-dev/neo-go/blob/740488f7f35e367eaa99a71c0a609c315fe2b0fc/pkg/core/transaction/witness.go#L10
fyrchik commented 2023-05-16 12:40:04 +00:00
Owner
Copy link

I believe, it is invocation script, not verification.

I believe, it is invocation script, not verification.
ale64bit commented 2023-05-16 12:59:53 +00:00
Author
Member
Copy link

done

done
fyrchik marked this conversation as resolved
cmd/frostfs-adm/internal/modules/morph/initialize.go Outdated
@ -52,6 +61,10 @@ func initializeSideChainCmd(cmd *cobra.Command, _ []string) error {
}
defer initCtx.close()
if len(initCtx.Accounts) > maxAlphabetNodes {
fyrchik commented 2023-05-16 12:40:49 +00:00
Owner
Copy link

What about failing inside newInitializeContext? This way we won't enter 23 passwords just to receive an error.

What about failing inside `newInitializeContext`? This way we won't enter 23 passwords just to receive an error.
ale64bit commented 2023-05-16 13:00:00 +00:00
Author
Member
Copy link

done

done
fyrchik marked this conversation as resolved
cmd/frostfs-adm/internal/modules/morph/initialize_register.go Outdated
@ -18,8 +18,8 @@ import (
"github.com/nspcc-dev/neo-go/pkg/vm/opcode"
)
// initialAlphabetNEOAmount represents the total amount of GAS distributed between alphabet nodes.
fyrchik commented 2023-05-16 12:41:02 +00:00
Owner
Copy link

unrelated to the commit.

unrelated to the commit.
ale64bit commented 2023-05-16 13:00:48 +00:00
Author
Member
Copy link

it's not unrelated. A new constant was added and this one was moved into a const block, so the comment needs to be nested as well since it refers to the specific constant and not to the whole block.

it's not unrelated. A new constant was added and this one was moved into a const block, so the comment needs to be nested as well since it refers to the specific constant and not to the whole block.
fyrchik commented 2023-05-17 06:39:08 +00:00
Owner
Copy link

I mean the change is valid, but new constant was added not in this PR, can we just move this change (comment move) to another commit?

All such minor things in combination make diffs bigger and harder to read.

I mean the change is valid, but new constant was added not in this PR, can we just move this change (comment move) to another commit? All such minor things in combination make diffs bigger and harder to read.
ale64bit commented 2023-05-17 07:35:56 +00:00
Author
Member
Copy link

done

done
fyrchik marked this conversation as resolved
cmd/frostfs-adm/internal/modules/morph/initialize_test.go Outdated
@ -46,3 +50,3 @@
}
func testInitialize(t *testing.T, committeeSize int) {
func testInitialize(t *testing.T, committeeSize int, wantErr error) {
fyrchik commented 2023-05-16 12:41:54 +00:00
Owner
Copy link

Can we just explicitly call generateTestData in the test instead of adding a parameter here?

Can we just explicitly call `generateTestData` in the test instead of adding a parameter here?
ale64bit commented 2023-05-16 13:01:13 +00:00
Author
Member
Copy link

we can. But what's the benefit?

we can. But what's the benefit?
fyrchik commented 2023-05-17 06:40:04 +00:00
Owner
Copy link

testInitialize tests initialization and checks all errors. It is not obvious, what error is expected here (for generation, initialization or sth else) and we use it only once.

`testInitialize` tests initialization and checks all errors. It is not obvious, what error is expected here (for generation, initialization or sth else) and we use it only once.
ale64bit commented 2023-05-17 07:35:40 +00:00
Author
Member
Copy link

done

done
fyrchik marked this conversation as resolved
cmd/frostfs-adm/internal/modules/morph/initialize_test.go Outdated
@ -82,2 +91,3 @@
func generateTestData(t *testing.T, dir string, size int) {
func generateTestData(t *testing.T, dir string, size int) error {
t.Helper()
fyrchik commented 2023-05-16 12:42:47 +00:00
Owner
Copy link

Why do we need this line?

Why do we need this line?
ale64bit commented 2023-05-16 13:03:15 +00:00
Author
Member
Copy link

Since this file is initialize_test.go and it tests initialization, I don't think this function should be calling test assertions since it's just a helper. This function marks it as such, so that it's skipped in the log to avoid verbose output.
We already have separate generate_test.go for testing generation specifically.

Since this file is `initialize_test.go` and it tests initialization, I don't think this function should be calling test assertions since it's just a helper. This function marks it as such, so that it's skipped in the log to avoid verbose output. We already have separate `generate_test.go` for testing generation specifically.
ale64bit commented 2023-05-16 13:22:36 +00:00
Author
Member
Copy link

Actually, I apologize. I had this call in an earlier version but in current form ofc it's not necessary. I removed it.

Actually, I apologize. I had this call in an earlier version but in current form ofc it's not necessary. I removed it.
fyrchik marked this conversation as resolved
ale64bit force-pushed fix/352-clarify-too-many-alpha-nodes from 7a9743272c to 20661a0bc7 2023-05-16 12:59:51 +00:00 Compare
ale64bit force-pushed fix/352-clarify-too-many-alpha-nodes from 20661a0bc7 to 52fd548060 2023-05-16 13:22:10 +00:00 Compare
dstepanov-yadro approved these changes 2023-05-16 14:31:43 +00:00
aarifullin approved these changes 2023-05-16 14:56:37 +00:00
ale64bit force-pushed fix/352-clarify-too-many-alpha-nodes from 52fd548060 to 99b4464674 2023-05-17 07:35:39 +00:00 Compare
fyrchik merged commit df9e099fa7 into master 2023-05-17 15:01:27 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
dstepanov-yadro
aarifullin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#354
No description provided.
Delete branch "ale64bit/frostfs-node:fix/352-clarify-too-many-alpha-nodes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?