adm: Refactor helper
in part of reading alphabet wallets #1203
No reviewers
Labels
No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No milestone
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-node#1203
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "acid-ant/frostfs-node:bugfix/morph-print-alphabet"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Close #218
Update doc for
morph generate-alphabet
.Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com
65afb6acac
toc8b6a36c45
@ -50,1 +43,3 @@
continue loop
var wallets []*wallet.Wallet
var letter string
innerring.IterateOverGlagoliticLetters(func(l string) (stop bool) {
I don't understand the purpose of
IterateGlagoliticLetters
, what is wrong with a simple for loop?Are we ok to make lastLetterNum public?
Do we need to? We already have a 23-node restriction anyway #352
For the case of required wallets for operation - no, we can use MaxAlphabetNodes.
For the case of printing all alphabet letters - yes.
@fyrchik updated, please review.
Regarding printing -- the command has static output, how about mentioning all names in the documentation?
Updated doc a bit.
c8b6a36c45
to73e00e7986
73e00e7986
tob3841e7054
adm: Add commandto adm: Refactormorph print-alphabet
helper
in part of reading alphabet wallets@fyrchik TestInitialize passed successfuly.
Log: