TrueCloudLab/frostfs-node
17
1
Fork 27
Code Issues 90 Pull requests 3 Projects Releases 1 Activity Actions

services/tree: Fast sorted listing #1059

Merged
fyrchik merged 1 commit from fyrchik/frostfs-node:fast-listing into master 2024-04-01 12:37:56 +00:00
Conversation 1 Commits 1 Files changed 10 +638 -29
fyrchik commented 2024-03-28 12:54:20 +00:00
Owner
Copy link
No description provided.
fyrchik added the
kludge
 label 2024-03-28 12:54:20 +00:00
fyrchik changed title from services/tree: Fast sorted listing to WIP: services/tree: Fast sorted listing 2024-03-28 12:54:36 +00:00
fyrchik force-pushed fast-listing from 42a2d61bc3 to 7cb9cd9eb0 2024-03-29 07:41:59 +00:00 Compare
fyrchik force-pushed fast-listing from 7cb9cd9eb0 to 336c3da181 2024-03-29 07:44:23 +00:00 Compare
fyrchik requested review from dkirillov 2024-03-29 10:24:54 +00:00
fyrchik requested review from storage-core-committers 2024-03-29 10:24:54 +00:00
fyrchik requested review from storage-core-developers 2024-03-29 10:24:54 +00:00
fyrchik force-pushed fast-listing from 336c3da181 to 7c6d540724 2024-03-29 10:29:17 +00:00 Compare
dkirillov commented 2024-03-29 10:39:32 +00:00
Member
Copy link

Looks good. In s3-gw we will fix using sort flag

Looks good. In s3-gw we will fix using sort flag
fyrchik changed title from WIP: services/tree: Fast sorted listing to services/tree: Fast sorted listing 2024-03-29 12:27:53 +00:00
dstepanov-yadro reviewed 2024-04-01 10:00:47 +00:00
pkg/local_object_storage/engine/tree.go Outdated
@ -212,0 +227,4 @@
nodes, cursor, err = sh.TreeSortedByFilename(ctx, cid, treeID, nodeID, last, count)
if err != nil {
if err == shard.ErrPiloramaDisabled {
break
dstepanov-yadro commented 2024-04-01 10:00:47 +00:00
Member
Copy link

continue, not break - pilorama could be disabled only on single shard

`continue`, not `break` - pilorama could be disabled only on single shard
fyrchik commented 2024-04-01 10:47:35 +00:00
Author
Owner
Copy link

No, it is a node-wide setting (tree.enabled). If it is disabled with shard mode, the error will be different.

No, it is a node-wide setting (`tree.enabled`). If it is disabled with shard mode, the error will be different.
dstepanov-yadro reviewed 2024-04-01 10:32:22 +00:00
pkg/local_object_storage/pilorama/forest.go Outdated
@ -156,1 +157,4 @@
// TreeSortedByFilename implements the Forest interface.
func (f *memoryForest) TreeSortedByFilename(_ context.Context, cid cid.ID, treeID string, nodeID Node, start string, count int) ([]NodeInfo, string, error) {
fmt.Println("LOG SORTED", nodeID, start, count)
dstepanov-yadro commented 2024-04-01 10:32:22 +00:00
Member
Copy link

debugee

debugee
👍 1
fyrchik commented 2024-04-01 10:50:11 +00:00
Author
Owner
Copy link

fixed

fixed
fyrchik force-pushed fast-listing from 7c6d540724 to 03073679a8 2024-04-01 10:48:29 +00:00 Compare
dstepanov-yadro approved these changes 2024-04-01 10:50:57 +00:00
acid-ant approved these changes 2024-04-01 11:15:23 +00:00
aarifullin approved these changes 2024-04-01 11:20:04 +00:00
aarifullin left a comment
Member
Copy link

Awesome

Awesome
fyrchik merged commit e12fcc041d into master 2024-04-01 12:37:52 +00:00
fyrchik deleted branch fast-listing 2024-04-10 08:09:00 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
dstepanov-yadro
acid-ant
aarifullin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1059
No description provided.
Delete branch "fyrchik/frostfs-node:fast-listing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?