TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 108 Pull requests 10 Projects Releases 2 Activity Actions

Fix pilorama sorted listing #1330

Merged
fyrchik merged 2 commits from fyrchik/frostfs-node:fix-pochtabank into master 2024-08-26 06:11:34 +00:00
Conversation 0 Commits 2 Files changed 3 +92 -8
fyrchik commented 2024-08-23 10:53:02 +00:00
Owner
Copy link
No description provided.
fyrchik added 2 commits 2024-08-23 10:53:26 +00:00 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
[#1328] pilorama: Do not skip items in SortedByFilename
All checks were successful
Tests and linters / Run gofumpt (pull_request) Successful in 2m46s
Details
DCO action / DCO (pull_request) Successful in 3m13s
Details
Vulncheck / Vulncheck (pull_request) Successful in 3m49s
Details
Build / Build Components (1.22) (pull_request) Successful in 4m11s
Details
Build / Build Components (1.23) (pull_request) Successful in 4m11s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 4m43s
Details
Tests and linters / Tests (1.22) (pull_request) Successful in 4m49s
Details
Tests and linters / Tests (1.23) (pull_request) Successful in 4m47s
Details
Tests and linters / Staticcheck (pull_request) Successful in 4m47s
Details
Tests and linters / Lint (pull_request) Successful in 5m8s
Details
Tests and linters / gopls check (pull_request) Successful in 5m7s
Details
Tests and linters / Tests with -race (pull_request) Successful in 5m13s
Details
a38f26b481 
Benchmark results:
```
goos: linux
goarch: amd64
pkg: git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/pilorama
cpu: 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz
                                   │     old     │                 new                 │
                                   │   sec/op    │   sec/op     vs base                │
ForestSortedIteration/bbolt,root-8   207.2µ ± 6%   173.6µ ± 6%  -16.23% (p=0.000 n=10)
ForestSortedIteration/bbolt,leaf-8   3.910µ ± 5%   3.928µ ± 7%        ~ (p=0.529 n=10)
geomean                              28.46µ        26.11µ        -8.27%
```

They are not representative, as the worst case is when we have multiple
items of different lengths. However, `FileName` is usually less than 100
in practice, so the asymptotics is the same.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
requested reviews from storage-core-committers, storage-core-developers 2024-08-23 10:53:45 +00:00
fyrchik added this to the v0.43.0 milestone 2024-08-23 10:53:59 +00:00
fyrchik added the
bug
 label 2024-08-23 10:54:08 +00:00
acid-ant approved these changes 2024-08-23 10:57:30 +00:00
dstepanov-yadro approved these changes 2024-08-23 11:25:49 +00:00
fyrchik merged commit 806ea37101 into master 2024-08-26 06:11:34 +00:00
fyrchik deleted branch fix-pochtabank 2024-08-26 06:11:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
dstepanov-yadro
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.43.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1330
No description provided.
Delete branch "fyrchik/frostfs-node:fix-pochtabank"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?