Use `range` over `int` after 1.22 upgrade #1345

Merged

fyrchik merged 1 commit from elebedeva/frostfs-node:feat/range-over-int-go1.22 into master

2024-09-03 11:26:44 +00:00

elebedeva commented

2024-08-30 16:39:59 +00:00

Member

Close #1317

Since Go 1.22 a for statement with a range clause is able to iterate through integer values from zero to an upper limit.

Files were changed via gopatch with a script:

@@
var i, e expression
@@
-for i := 0; i <= e - 1; i++ {
+for i := range e {
    ...
}

@@
var i, e expression
@@
-for i := 0; i <= e; i++ {
+for i := range e + 1 {
    ...
}

@@
var i, e expression
@@
-for i := 0; i < e; i++ {
+for i := range e {
    ...
}

Unused identifiers were removed manually. 🥲

Signed-off-by: Ekaterina Lebedeva ekaterina.lebedeva@yadro.com

Close #1317 Since Go 1.22 a `for` statement with a `range` clause is able to iterate through integer values from zero to an upper limit. Files were changed via [`gopatch`](https://github.com/uber-go/gopatch) with a script: ``` @@ var i, e expression @@ -for i := 0; i <= e - 1; i++ { +for i := range e { ... } @@ var i, e expression @@ -for i := 0; i <= e; i++ { +for i := range e + 1 { ... } @@ var i, e expression @@ -for i := 0; i < e; i++ { +for i := range e { ... } ``` Unused identifiers were removed manually. 🥲 Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>

elebedeva added the

refactoring

internal

labels 2024-08-30 16:39:59 +00:00

elebedeva added 1 commit 2024-08-30 16:40:05 +00:00

[#1317 ] go.mod: Use range over int

DCO action / DCO (pull_request) Successful in 1m49s

Details

Tests and linters / Run gofumpt (pull_request) Successful in 2m15s

Details

Pre-commit hooks / Pre-commit (pull_request) Successful in 2m41s

Details

Build / Build Components (1.22) (pull_request) Successful in 2m49s

Details

Build / Build Components (1.23) (pull_request) Successful in 2m48s

Details

Vulncheck / Vulncheck (pull_request) Successful in 2m30s

Details

Tests and linters / Tests (1.22) (pull_request) Successful in 3m45s

Details

Tests and linters / Staticcheck (pull_request) Successful in 3m49s

Details

Tests and linters / Tests (1.23) (pull_request) Successful in 3m52s

Details

Tests and linters / gopls check (pull_request) Successful in 4m25s

Details

Tests and linters / Lint (pull_request) Successful in 4m44s

Details

Tests and linters / Tests with -race (pull_request) Successful in 4m39s

Details

1a17a5594c

Since Go 1.22 a "for" statement with a "range" clause is able
to iterate through integer values from zero to an upper limit.

Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>

elebedeva requested review from storage-core-committers 2024-08-30 16:45:55 +00:00

elebedeva requested review from storage-core-developers 2024-08-30 16:45:55 +00:00