TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 6 Projects Releases 1 Activity Actions

Update frostfs-sdk-go and frostfs-api-go versions #1382

Merged
dstepanov-yadro merged 1 commit from dstepanov-yadro/frostfs-node:feat/upgrade-skd-and-api-go into master 2024-10-26 11:30:26 +00:00
Conversation 0 Commits 1 Files changed 1 +4 -4
dstepanov-yadro commented 2024-09-18 11:09:10 +00:00
Member
Copy link
  • frostfs-sdk-go and frostfs-api-go versions updated
  • deprecated methods replaced
- `frostfs-sdk-go` and `frostfs-api-go` versions updated - deprecated methods replaced
dstepanov-yadro added 7 commits 2024-09-18 11:09:11 +00:00 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
[#9999] cli: Replace deprecated methods
Some checks failed
DCO action / DCO (pull_request) Successful in 56s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 1m21s
Details
Vulncheck / Vulncheck (pull_request) Successful in 1m53s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m22s
Details
Build / Build Components (pull_request) Successful in 2m30s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m41s
Details
Tests and linters / gopls check (pull_request) Successful in 2m54s
Details
Tests and linters / Tests (pull_request) Successful in 4m15s
Details
Tests and linters / Tests with -race (pull_request) Successful in 5m52s
Details
Tests and linters / Lint (pull_request) Failing after 2m31s
Details
c4322a6943 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
achuprov approved these changes 2024-09-18 11:23:35 +00:00
Dismissed
dstepanov-yadro force-pushed feat/upgrade-skd-and-api-go from c4322a6943 to 6cb65aea35 2024-09-18 11:30:02 +00:00 Compare
dstepanov-yadro force-pushed feat/upgrade-skd-and-api-go from 6cb65aea35 to 3441fff05d 2024-09-18 11:39:41 +00:00 Compare
dstepanov-yadro dismissed achuprov's review 2024-09-18 11:39:41 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dstepanov-yadro reviewed 2024-09-18 11:41:50 +00:00
cmd/frostfs-node/netmap.go
@ -69,2 +69,3 @@
case ni.IsMaintenance():
case netmapSDK.Maintenance:
ctrlNetSt = control.NetmapStatus_MAINTENANCE
case netmapSDK.UnspecifiedState:
dstepanov-yadro commented 2024-09-18 11:41:49 +00:00
Author
Member
Copy link

Linter fix: by default ctrlNetSt := control.NetmapStatus_STATUS_UNDEFINED (line 59)

Linter fix: by default `ctrlNetSt := control.NetmapStatus_STATUS_UNDEFINED` (line 59)
dstepanov-yadro reviewed 2024-09-18 11:42:24 +00:00
cmd/frostfs-node/netmap.go
@ -271,2 +273,3 @@
case ni.IsMaintenance():
case netmapSDK.Maintenance:
return "maintenance"
case netmapSDK.UnspecifiedState:
dstepanov-yadro commented 2024-09-18 11:42:24 +00:00
Author
Member
Copy link

Linter fix: return "undefined" by default (line 279)

Linter fix: `return "undefined"` by default (line 279)
dstepanov-yadro requested review from storage-core-developers 2024-09-18 11:47:49 +00:00
dstepanov-yadro requested review from storage-core-committers 2024-09-18 11:47:50 +00:00
achuprov approved these changes 2024-09-18 15:23:14 +00:00
aarifullin approved these changes 2024-09-19 08:16:00 +00:00
dstepanov-yadro merged commit 3441fff05d into master 2024-09-19 08:18:56 +00:00
dstepanov-yadro deleted branch feat/upgrade-skd-and-api-go 2024-09-19 08:18:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
achuprov
aarifullin
TrueCloudLab/storage-core-committers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1382
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:feat/upgrade-skd-and-api-go"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?