Fix FrostfsID cache #1464

dstepanov-yadro · 2024-10-30T14:47:52Z

dstepanov-yadro commented

2024-10-30 14:47:52 +00:00

Add cache metrics
Cache subject not found error as it is expected by callers error

Perf test 5 min, 600 writers, 8kb

Before:

     data_received..............: 0 B     0 B/s
     data_sent..................: 9.9 GB  33 MB/s
     frostfs_obj_put_bytes......: 9.9 GB  33 MB/s
     frostfs_obj_put_duration...: avg=148.3ms  min=9.03ms   med=134.69ms max=1.43s p(90)=241.97ms p(95)=284.08ms
     frostfs_obj_put_success....: 1206886 4020.709226/s
     iteration_duration.........: avg=149.14ms min=128.91µs med=135.52ms max=1.43s p(90)=242.89ms p(95)=285ms   
     iterations.................: 1206886 4020.709226/s
     vus........................: 600     min=600       max=600

After:

     data_received..............: 0 B     0 B/s
     data_sent..................: 19 GB   63 MB/s
     frostfs_obj_put_bytes......: 19 GB   63 MB/s
     frostfs_obj_put_duration...: avg=77.18ms min=7.62ms   med=63.38ms max=1.12s p(90)=131.28ms p(95)=173.69ms
     frostfs_obj_put_success....: 2309080 7694.787607/s
     iteration_duration.........: avg=77.92ms min=129.31µs med=64.11ms max=1.12s p(90)=132.15ms p(95)=174.53ms
     iterations.................: 2309080 7694.787607/s
     vus........................: 600     min=600       max=600

Found with #1462

1. Add cache metrics 2. Cache `subject not found` error as it is expected by callers error Perf test 5 min, 600 writers, 8kb Before: ``` data_received..............: 0 B 0 B/s data_sent..................: 9.9 GB 33 MB/s frostfs_obj_put_bytes......: 9.9 GB 33 MB/s frostfs_obj_put_duration...: avg=148.3ms min=9.03ms med=134.69ms max=1.43s p(90)=241.97ms p(95)=284.08ms frostfs_obj_put_success....: 1206886 4020.709226/s iteration_duration.........: avg=149.14ms min=128.91µs med=135.52ms max=1.43s p(90)=242.89ms p(95)=285ms iterations.................: 1206886 4020.709226/s vus........................: 600 min=600 max=600 ``` After: ``` data_received..............: 0 B 0 B/s data_sent..................: 19 GB 63 MB/s frostfs_obj_put_bytes......: 19 GB 63 MB/s frostfs_obj_put_duration...: avg=77.18ms min=7.62ms med=63.38ms max=1.12s p(90)=131.28ms p(95)=173.69ms frostfs_obj_put_success....: 2309080 7694.787607/s iteration_duration.........: avg=77.92ms min=129.31µs med=64.11ms max=1.12s p(90)=132.15ms p(95)=174.53ms iterations.................: 2309080 7694.787607/s vus........................: 600 min=600 max=600 ``` ![image](/attachments/94335bad-1945-4964-bb44-9a4e4df3a58e) Found with https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/1462

image.png

65 KiB

dstepanov-yadro force-pushed fix/frostfsid_cache from cd5f4ec0a9 to 6e8f5892bc

2024-10-30 14:48:59 +00:00

Compare

dstepanov-yadro force-pushed fix/frostfsid_cache from 6e8f5892bc to f51f3c381b

2024-10-30 14:49:57 +00:00

Compare

dstepanov-yadro reviewed 2024-10-30 14:51:32 +00:00

cmd/frostfs-node/frostfsid.go Outdated

					
				@ -54,0 +88,4 @@

							m.subjExtCache.Add(addr, subjectExtWithError{

								err: err,

							})

							m.subjCache.Add(addr, subjectWithError{