TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

Fix FrostfsID cache #1464

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:fix/frostfsid_cache into master 2024-11-02 14:21:42 +00:00
Conversation 0 Commits 1 Files changed 1 +42 -11
dstepanov-yadro commented 2024-10-30 14:47:52 +00:00
Member
Copy link
  1. Add cache metrics
  2. Cache subject not found error as it is expected by callers error

Perf test 5 min, 600 writers, 8kb

Before:

     data_received..............: 0 B     0 B/s
     data_sent..................: 9.9 GB  33 MB/s
     frostfs_obj_put_bytes......: 9.9 GB  33 MB/s
     frostfs_obj_put_duration...: avg=148.3ms  min=9.03ms   med=134.69ms max=1.43s p(90)=241.97ms p(95)=284.08ms
     frostfs_obj_put_success....: 1206886 4020.709226/s
     iteration_duration.........: avg=149.14ms min=128.91µs med=135.52ms max=1.43s p(90)=242.89ms p(95)=285ms   
     iterations.................: 1206886 4020.709226/s
     vus........................: 600     min=600       max=600

After:

     data_received..............: 0 B     0 B/s
     data_sent..................: 19 GB   63 MB/s
     frostfs_obj_put_bytes......: 19 GB   63 MB/s
     frostfs_obj_put_duration...: avg=77.18ms min=7.62ms   med=63.38ms max=1.12s p(90)=131.28ms p(95)=173.69ms
     frostfs_obj_put_success....: 2309080 7694.787607/s
     iteration_duration.........: avg=77.92ms min=129.31µs med=64.11ms max=1.12s p(90)=132.15ms p(95)=174.53ms
     iterations.................: 2309080 7694.787607/s
     vus........................: 600     min=600       max=600

image

Found with #1462

1. Add cache metrics 2. Cache `subject not found` error as it is expected by callers error Perf test 5 min, 600 writers, 8kb Before: ``` data_received..............: 0 B 0 B/s data_sent..................: 9.9 GB 33 MB/s frostfs_obj_put_bytes......: 9.9 GB 33 MB/s frostfs_obj_put_duration...: avg=148.3ms min=9.03ms med=134.69ms max=1.43s p(90)=241.97ms p(95)=284.08ms frostfs_obj_put_success....: 1206886 4020.709226/s iteration_duration.........: avg=149.14ms min=128.91µs med=135.52ms max=1.43s p(90)=242.89ms p(95)=285ms iterations.................: 1206886 4020.709226/s vus........................: 600 min=600 max=600 ``` After: ``` data_received..............: 0 B 0 B/s data_sent..................: 19 GB 63 MB/s frostfs_obj_put_bytes......: 19 GB 63 MB/s frostfs_obj_put_duration...: avg=77.18ms min=7.62ms med=63.38ms max=1.12s p(90)=131.28ms p(95)=173.69ms frostfs_obj_put_success....: 2309080 7694.787607/s iteration_duration.........: avg=77.92ms min=129.31µs med=64.11ms max=1.12s p(90)=132.15ms p(95)=174.53ms iterations.................: 2309080 7694.787607/s vus........................: 600 min=600 max=600 ``` ![image](/attachments/94335bad-1945-4964-bb44-9a4e4df3a58e) Found with https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/1462
image.png
65 KiB
dstepanov-yadro added 2 commits 2024-10-30 14:47:52 +00:00 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
[#9999] frostfsid: Cache subject not found error
All checks were successful
Tests and linters / Run gofumpt (pull_request) Successful in 2m21s
Details
DCO action / DCO (pull_request) Successful in 2m38s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m48s
Details
Vulncheck / Vulncheck (pull_request) Successful in 3m31s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m56s
Details
Build / Build Components (pull_request) Successful in 4m12s
Details
Tests and linters / gopls check (pull_request) Successful in 4m0s
Details
Tests and linters / Lint (pull_request) Successful in 5m8s
Details
Tests and linters / Tests (pull_request) Successful in 10m28s
Details
Tests and linters / Tests with -race (pull_request) Successful in 10m59s
Details
cd5f4ec0a9 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed fix/frostfsid_cache from cd5f4ec0a9 to 6e8f5892bc 2024-10-30 14:48:59 +00:00 Compare
dstepanov-yadro force-pushed fix/frostfsid_cache from 6e8f5892bc to f51f3c381b 2024-10-30 14:49:57 +00:00 Compare
dstepanov-yadro reviewed 2024-10-30 14:51:32 +00:00
cmd/frostfs-node/frostfsid.go Outdated
@ -54,0 +88,4 @@
m.subjExtCache.Add(addr, subjectExtWithError{
err: err,
})
m.subjCache.Add(addr, subjectWithError{
dstepanov-yadro commented 2024-10-30 14:51:32 +00:00
Author
Member
Copy link

As now only subject not found error is cacheable, it is safe to update both caches

As now only `subject not found` error is cacheable, it is safe to update both caches
dstepanov-yadro force-pushed fix/frostfsid_cache from f51f3c381b to 32be596c2d 2024-10-30 14:52:38 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2024-10-30 15:01:01 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-10-30 15:01:01 +00:00
dstepanov-yadro force-pushed fix/frostfsid_cache from 32be596c2d to 2285cfc36f 2024-10-30 15:27:42 +00:00 Compare
fyrchik approved these changes 2024-10-31 06:18:23 +00:00
acid-ant approved these changes 2024-10-31 06:33:05 +00:00
fyrchik merged commit 2285cfc36f into master 2024-10-31 06:39:43 +00:00
fyrchik referenced this pull request from a commit 2024-10-31 06:39:45 +00:00
[#1464] frostfsid: Add cache metrics
dstepanov-yadro deleted branch fix/frostfsid_cache 2024-10-31 06:56:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
acid-ant
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1464
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/frostfsid_cache"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?