TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 109 Pull requests 2 Projects Releases 1 Activity Actions

[SUPPORT] Introduce ChainRouterError error type and wrap only these errors with ObjectAccessDenied status #1565

Merged
fyrchik merged 3 commits from aarifullin/frostfs-node:fix/ape_logicalerr_sprt into support/v0.44 2024-12-17 08:18:09 +00:00
Conversation 0 Commits 3 Files changed 4 +50 -1
aarifullin commented 2024-12-16 13:01:32 +00:00
Member
Copy link
  • Introduce ChainRouterError in common/ape package
  • Refactor tree service. Make tree service wrap with ObjectAccessDenied only ChainRouterError
  • Refactor object service. Make object service wrap with ObjectAccessDenied only ChainRouterError

Since errors can be differentiated logical check errors and server internal errors.

* Introduce `ChainRouterError` in `common/ape` package * Refactor `tree` service. Make `tree` service wrap with `ObjectAccessDenied` only `ChainRouterError` * Refactor `object` service. Make `object` service wrap with `ObjectAccessDenied` only `ChainRouterError` Since errors can be differentiated logical check errors and server internal errors.
aarifullin added 3 commits 2024-12-16 13:01:32 +00:00 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
* Such wrapping helps to differentiate logical check errors and server internal
  errors.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
[#1563] tree: Wrap only ChainRouterError erros with ObjectAccessDenied
All checks were successful
Pre-commit hooks / Pre-commit (pull_request) Successful in 3m28s
Details
Vulncheck / Vulncheck (pull_request) Successful in 3m52s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 5m18s
Details
Tests and linters / Lint (pull_request) Successful in 5m37s
Details
DCO action / DCO (pull_request) Successful in 5m42s
Details
Tests and linters / gopls check (pull_request) Successful in 5m47s
Details
Tests and linters / Staticcheck (pull_request) Successful in 7m39s
Details
Build / Build Components (pull_request) Successful in 7m52s
Details
Tests and linters / Tests (pull_request) Successful in 7m51s
Details
Tests and linters / Tests with -race (pull_request) Successful in 9m5s
Details
c78546c7b5 
* Such wrapping helps to differentiate logical check errors and server internal
  errors.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin requested review from storage-core-committers 2024-12-16 13:01:33 +00:00
aarifullin requested review from storage-core-developers 2024-12-16 13:01:33 +00:00
aarifullin changed title from [SUPPORT] Introduce ChainRouterError error type and wrap only these errors with ObjectAccessDenied status to WIP: [SUPPORT] Introduce ChainRouterError error type and wrap only these errors with ObjectAccessDenied status 2024-12-16 13:02:06 +00:00
aarifullin force-pushed fix/ape_logicalerr_sprt from c78546c7b5 to 94b0ceb0b8 2024-12-16 13:08:59 +00:00 Compare
aarifullin changed title from WIP: [SUPPORT] Introduce ChainRouterError error type and wrap only these errors with ObjectAccessDenied status to [SUPPORT] Introduce ChainRouterError error type and wrap only these errors with ObjectAccessDenied status 2024-12-16 13:09:29 +00:00
aarifullin changed title from [SUPPORT] Introduce ChainRouterError error type and wrap only these errors with ObjectAccessDenied status to WIP: [SUPPORT] Introduce ChainRouterError error type and wrap only these errors with ObjectAccessDenied status 2024-12-16 13:09:51 +00:00
aarifullin force-pushed fix/ape_logicalerr_sprt from 94b0ceb0b8 to ad89b3ee53 2024-12-16 13:15:18 +00:00 Compare
aarifullin force-pushed fix/ape_logicalerr_sprt from ad89b3ee53 to 7e3f2fca47 2024-12-16 13:19:29 +00:00 Compare
aarifullin changed title from WIP: [SUPPORT] Introduce ChainRouterError error type and wrap only these errors with ObjectAccessDenied status to [SUPPORT] Introduce ChainRouterError error type and wrap only these errors with ObjectAccessDenied status 2024-12-16 13:19:44 +00:00
acid-ant approved these changes 2024-12-16 14:57:33 +00:00
fyrchik approved these changes 2024-12-17 08:17:43 +00:00
fyrchik requested review from dkirillov 2024-12-17 08:17:56 +00:00
fyrchik merged commit 7e3f2fca47 into support/v0.44 2024-12-17 08:18:09 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
dkirillov
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1565
No description provided.
Delete branch "aarifullin/frostfs-node:fix/ape_logicalerr_sprt"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?