TrueCloudLab/frostfs-node

Fork 27

[#181] ir: Do not deposit notary GAS by non-alphabet nodes #187

Merged

fyrchik merged 1 commit from carpawell/frostfs-node:fix/IRs-do-not-do-deposits into master

2023-07-26 21:07:57 +00:00

carpawell commented

2023-03-29 15:07:17 +00:00

Member

Do not know what "IR" (non-Alphabet) means then cause audit gonna be dropped soon, SGs are not adopted and the problem from the issue, in fact, is not about notary requests but is about zero balances but ok, that PR fixes infinite IR restarts.

Closes #181.

carpawell self-assigned this 2023-03-29 15:07:17 +00:00

carpawell added 1 commit 2023-03-29 15:07:19 +00:00

[#181 ] ir: Do not deposit notary GAS by non-alphabet nodes

ci/woodpecker/pr/pre-commit Pipeline was successful

Details

e71b6582b5

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>

carpawell requested review from storage-core-developers 2023-03-29 15:07:36 +00:00

carpawell requested review from storage-core-committers 2023-03-29 15:07:51 +00:00

carpawell requested review from fyrchik 2023-03-29 15:07:55 +00:00

carpawell referenced this pull request

2023-03-29 15:11:15 +00:00

[#181] ir: Do not deposit notary GAS by non-alphabet nodes #186

acid-ant approved these changes 2023-03-30 06:53:09 +00:00

dstepanov-yadro approved these changes 2023-03-30 06:58:30 +00:00

fyrchik commented

2023-03-30 07:28:38 +00:00

Owner

In the runtime there still could be some error logs regarding non-alphabet state:

мар 28 13:23:11 nash frostfs-ir[14466]: 2023-03-28T13:23:11.823Z        warn        innerring/blocktimer.go:104        can't stop epoch estimation        {"epoch": 2, "error": "could not invoke method (stopContainerEstimation): frostfs error: can't convert account to inner ring multisig wallet: own public key was not found among multisig keys"}

In the runtime there still could be some error logs regarding non-alphabet state: ``` мар 28 13:23:11 nash frostfs-ir[14466]: 2023-03-28T13:23:11.823Z warn innerring/blocktimer.go:104 can't stop epoch estimation {"epoch": 2, "error": "could not invoke method (stopContainerEstimation): frostfs error: can't convert account to inner ring multisig wallet: own public key was not found among multisig keys"} ```

carpawell added 3 commits 2023-03-30 15:25:57 +00:00

[#139 ] test: Add test storage implementation

ci/woodpecker/push/pre-commit Pipeline was successful

Details

341fe1688f

This aims to reduce the usage of chmod hackery to induce or simulate
OS-related failures.

Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>

[#183 ] gc: Fix drop expired locked simple objects 9f0bce5c15

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>

[#183 ] gc: Fix drop expired locked complex objects

ci/woodpecker/push/pre-commit Pipeline was successful

Details

ab32067152

Do not delete bucket keys during iteration

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>

carpawell force-pushed fix/IRs-do-not-do-deposits from 6f131552e1 to e17f6eb831

2023-03-30 15:33:45 +00:00

Compare

carpawell commented

2023-03-30 15:34:08 +00:00

Author

Member

@fyrchik, rechecked one more time.

carpawell requested review from dstepanov-yadro 2023-03-30 15:34:13 +00:00

carpawell requested review from acid-ant 2023-03-30 15:34:15 +00:00

carpawell requested review from storage-core-developers 2023-03-30 15:34:24 +00:00

carpawell requested review from storage-core-committers 2023-03-30 15:34:24 +00:00

carpawell force-pushed fix/IRs-do-not-do-deposits from e17f6eb831 to ffd19e188d

2023-03-30 15:35:35 +00:00

Compare

dstepanov-yadro approved these changes 2023-03-30 15:42:33 +00:00

fyrchik approved these changes 2023-03-31 09:20:37 +00:00

carpawell force-pushed fix/IRs-do-not-do-deposits from ffd19e188d to 2bdf7126b8

2023-03-31 09:58:19 +00:00

Compare

carpawell commented

2023-03-31 09:58:45 +00:00

Author

Member

Fixed conflicts.

carpawell requested review from dstepanov-yadro 2023-03-31 09:59:09 +00:00

carpawell requested review from fyrchik 2023-03-31 09:59:11 +00:00

dstepanov-yadro approved these changes 2023-03-31 10:04:26 +00:00

fyrchik approved these changes 2023-04-03 08:29:22 +00:00

fyrchik merged commit 2bdf7126b8 into master

2023-04-03 08:29:32 +00:00

No reviewers

No labels

No milestone

No project

No assignees

4 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#187

No description provided.