TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 108 Pull requests 6 Projects Releases 2 Activity Actions

[#116] node: Fix bug with extra generated files in TestReload #220

Merged
fyrchik merged 1 commit from aarifullin/frostfs-node:fix/116-generated_extra_files into master 2023-04-06 07:02:43 +00:00
Conversation 0 Commits 1 Files changed 1 +3 -1
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pkg/local_object_storage/engine/control_test.go
View file

@ -25,6 +25,7 @@ import (
"github.com/stretchr/testify/require" "github.com/stretchr/testify/require"
"go.etcd.io/bbolt" "go.etcd.io/bbolt"
"go.uber.org/atomic" "go.uber.org/atomic"
"go.uber.org/zap"
"go.uber.org/zap/zaptest" "go.uber.org/zap/zaptest"
) )
@ -321,8 +322,9 @@ func engineWithShards(t *testing.T, path string, num int) (*StorageEngine, []str
currShards := make([]string, 0, num) currShards := make([]string, 0, num)
te := testNewEngine(t). te := testNewEngine(t).
setShardsNumAdditionalOpts(t, num, func(id int) []shard.Option { setShardsNumOpts(t, num, func(id int) []shard.Option {
aarifullin commented 2023-04-05 15:53:26 +00:00
Review
Copy link

@dstepanov-yadro noticed that tests generate extra *.pilorama files. It turned out that default shards have set Pilorama option that led to generating extra *.pilorama files in TestReload

@dstepanov-yadro noticed that tests generate extra `*.pilorama` files. It turned out that default shards have set `Pilorama` option that led to generating extra `*.pilorama` files in `TestReload`
return []shard.Option{ return []shard.Option{
shard.WithLogger(&logger.Logger{Logger: zap.L()}),
shard.WithBlobStorOptions( shard.WithBlobStorOptions(
blobstor.WithStorages(newStorages(filepath.Join(addPath, strconv.Itoa(id)), errSmallSize))), blobstor.WithStorages(newStorages(filepath.Join(addPath, strconv.Itoa(id)), errSmallSize))),
shard.WithMetaBaseOptions( shard.WithMetaBaseOptions(