[#524] cli: Add impersonate flag for bearer token creation #524

Merged
fyrchik merged 1 commit from dkirillov/frostfs-node:feature/cli-add_impersonate_flag_to_bearer_token into master 2023-07-17 08:20:53 +00:00
Member

Signed-off-by: Denis Kirillov d.kirillov@yadro.com

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov self-assigned this 2023-07-14 13:09:02 +00:00
dkirillov changed title from [#XX] cli: Add impersonate flag for bearer token creation to WIP: [#XX] cli: Add impersonate flag for bearer token creation 2023-07-14 13:09:09 +00:00
dkirillov changed title from WIP: [#XX] cli: Add impersonate flag for bearer token creation to WIP: [#524] cli: Add impersonate flag for bearer token creation 2023-07-14 13:09:17 +00:00
dkirillov force-pushed feature/cli-add_impersonate_flag_to_bearer_token from 059a560ae5 to 70d85101d8 2023-07-14 13:09:34 +00:00 Compare
dkirillov changed title from WIP: [#524] cli: Add impersonate flag for bearer token creation to [#524] cli: Add impersonate flag for bearer token creation 2023-07-14 13:09:49 +00:00
dkirillov requested review from alexvanin 2023-07-14 13:10:04 +00:00
dkirillov requested review from EliChin 2023-07-14 13:10:04 +00:00
dkirillov requested review from storage-core-developers 2023-07-14 13:10:04 +00:00
dkirillov requested review from storage-core-committers 2023-07-14 13:10:04 +00:00
ironbee approved these changes 2023-07-14 13:19:37 +00:00
dstepanov-yadro approved these changes 2023-07-14 13:43:49 +00:00
EliChin approved these changes 2023-07-14 14:10:53 +00:00
@ -46,3 +47,4 @@
createCmd.Flags().StringP(ownerFlag, "o", "", "Token owner")
createCmd.Flags().String(outFlag, "", "File to write token to")
createCmd.Flags().Bool(jsonFlag, false, "Output token in JSON")
createCmd.Flags().Bool(impersonateFlag, false, "Mark token as impersonate to consider token signer as request owner (mutually exclusive with --eacl flag)")
Member

Mark token as impersonate to consider token signer as request owner

Mark token as impersonate to consider the token signer as the request owner

> Mark token as impersonate to consider token signer as request owner Mark token as impersonate to consider the token signer as the request owner
dkirillov force-pushed feature/cli-add_impersonate_flag_to_bearer_token from 70d85101d8 to fd6b8336bc 2023-07-14 14:32:09 +00:00 Compare
fyrchik reviewed 2023-07-15 09:45:55 +00:00
@ -104,2 +108,4 @@
eaclPath, _ := cmd.Flags().GetString(eaclFlag)
if eaclPath != "" {
if impersonate {
Owner

Why not mark them as exclusive on a cobra level?

Why not mark them as exclusive on a `cobra` level?
dkirillov force-pushed feature/cli-add_impersonate_flag_to_bearer_token from fd6b8336bc to ec8a44f73c 2023-07-17 06:33:47 +00:00 Compare
fyrchik approved these changes 2023-07-17 08:20:36 +00:00
fyrchik merged commit 486287c2f7 into master 2023-07-17 08:20:53 +00:00
Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-core-developers
No milestone
No project
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#524
No description provided.