cli: Add context to policy parsing errors #683

fyrchik · 2023-09-12T07:46:28Z

fyrchik commented

2023-09-12 07:46:28 +00:00

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

fyrchik force-pushed parsing-error from f50137da3a to 97bb1bf36f

2023-09-12 07:47:04 +00:00

Compare

fyrchik requested review from storage-core-committers 2023-09-12 07:47:12 +00:00

fyrchik requested review from storage-core-developers 2023-09-12 07:47:58 +00:00

fyrchik added this to the v0.37.0 milestone 2023-09-12 07:48:01 +00:00

aarifullin reviewed 2023-09-12 07:52:51 +00:00

cmd/frostfs-cli/modules/container/create.go

					
				@ -186,3 +186,3 @@

					}

					if err = result.UnmarshalJSON([]byte(policyString)); err == nil {

					if err := result.UnmarshalJSON([]byte(policyString)); err == nil {

aarifullin commented

2023-09-12 07:52:51 +00:00

It looks unnatural for Go language :)

Can you swap these lines please

if err := result.UnmarshalJSON([]byte(policyString)); err != nil {
   return nil, fmt.Errorf("can't parse placement policy: %w", err)
}

common.PrintVerbose(cmd, "Parsed JSON encoded policy")
return &result, nil

It looks unnatural for Go language :) Can you swap these lines please ```golang if err := result.UnmarshalJSON([]byte(policyString)); err != nil { return nil, fmt.Errorf("can't parse placement policy: %w", err) } common.PrintVerbose(cmd, "Parsed JSON encoded policy") return &result, nil ```

fyrchik commented

2023-09-12 08:49:33 +00:00

It will become incorrect then -- we intentionally return an error from DecodeString

It will become incorrect then -- we intentionally return an error from `DecodeString`

aarifullin commented

2023-09-12 09:44:50 +00:00

ah, ok