TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 108 Pull requests 6 Projects Releases 2 Activity Actions

cli: Add context to policy parsing errors #683

Merged
fyrchik merged 1 commit from fyrchik/frostfs-node:parsing-error into master 2023-09-12 09:47:22 +00:00
Conversation 0 Commits 1 Files changed 1 +2 -2
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
cmd/frostfs-cli/modules/container/create.go
View file

@ -185,12 +185,12 @@ func parseContainerPolicy(cmd *cobra.Command, policyString string) (*netmap.Plac
return &result, nil
}
if err = result.UnmarshalJSON([]byte(policyString)); err == nil {
if err := result.UnmarshalJSON([]byte(policyString)); err == nil {
aarifullin commented 2023-09-12 07:52:51 +00:00
Review
Copy link

It looks unnatural for Go language :)

Can you swap these lines please

if err := result.UnmarshalJSON([]byte(policyString)); err != nil {
   return nil, fmt.Errorf("can't parse placement policy: %w", err)
}

common.PrintVerbose(cmd, "Parsed JSON encoded policy")
return &result, nil
It looks unnatural for Go language :) Can you swap these lines please ```golang if err := result.UnmarshalJSON([]byte(policyString)); err != nil { return nil, fmt.Errorf("can't parse placement policy: %w", err) } common.PrintVerbose(cmd, "Parsed JSON encoded policy") return &result, nil ```
fyrchik commented 2023-09-12 08:49:33 +00:00
Review
Copy link

It will become incorrect then -- we intentionally return an error from DecodeString

It will become incorrect then -- we intentionally return an error from `DecodeString`
aarifullin commented 2023-09-12 09:44:50 +00:00
Review
Copy link

ah, ok

ah, ok
common.PrintVerbose(cmd, "Parsed JSON encoded policy")
return &result, nil
}
return nil, errors.New("can't parse placement policy")
return nil, fmt.Errorf("can't parse placement policy: %w", err)
}
func parseAttributes(dst *container.Container, attributes []string) error {