node: Put in log info about listening endpoints #714

acid-ant · 2023-10-02T07:42:03Z

acid-ant commented

2023-10-02 07:42:03 +00:00

Close #709

Logs example:

2023-10-02T09:12:54.899Z	info	frostfs-node/grpc.go:113	start listening endpoint	{"service": "gRPC", "endpoint": "192.168.130.72:8080"}
2023-10-02T09:12:55.905Z	info	frostfs-node/control.go:72	start listening endpoint	{"service": "control", "endpoint": "s02.frostfs.devenv:8081"}
2023-10-02T09:12:55.905Z	info	frostfs-node/httpcomponent.go:47	start listening endpoint	{"service": "pprof", "endpoint": ":6060"}
2023-10-02T09:12:55.905Z	info	frostfs-node/httpcomponent.go:47	start listening endpoint	{"service": "metrics", "endpoint": ":9090"}

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Close #709 Logs example: ``` 2023-10-02T09:12:54.899Z info frostfs-node/grpc.go:113 start listening endpoint {"service": "gRPC", "endpoint": "192.168.130.72:8080"} 2023-10-02T09:12:55.905Z info frostfs-node/control.go:72 start listening endpoint {"service": "control", "endpoint": "s02.frostfs.devenv:8081"} 2023-10-02T09:12:55.905Z info frostfs-node/httpcomponent.go:47 start listening endpoint {"service": "pprof", "endpoint": ":6060"} 2023-10-02T09:12:55.905Z info frostfs-node/httpcomponent.go:47 start listening endpoint {"service": "metrics", "endpoint": ":9090"} ``` Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>

requested reviews from storage-core-committers, storage-core-developers

2023-10-02 07:42:19 +00:00

fyrchik approved these changes 2023-10-02 08:56:56 +00:00

cmd/frostfs-node/httpcomponent.go Outdated

					
				@ -42,6 +43,8 @@ func (cmp *httpComponent) init(c *cfg) {

						cmp.name,

						func(ctx context.Context) {

							runAndLog(ctx, c, cmp.name, false, func(context.Context, *cfg) {

								c.log.Info(fmt.Sprintf("start listening %s endpoint", cmp.name),

fyrchik commented

2023-10-02 08:56:54 +00:00

How about zap.String("service", cmp.name)?

How about `zap.String("service", cmp.name)`?

acid-ant commented

2023-10-02 09:18:20 +00:00

Much better, updated.

acid-ant force-pushed bugfix/709-log-interface from 918f08d106 to 1a1a739bd8

2023-10-02 09:17:43 +00:00

Compare

fyrchik reviewed 2023-10-02 10:14:52 +00:00

cmd/frostfs-node/httpcomponent.go Outdated

					
				@ -42,6 +44,9 @@ func (cmp *httpComponent) init(c *cfg) {

						cmp.name,

						func(ctx context.Context) {

							runAndLog(ctx, c, cmp.name, false, func(context.Context, *cfg) {

								c.log.Info(fmt.Sprintf(logs.FrostFSNodeStartListeningEndpoint),

fyrchik commented

2023-10-02 10:14:52 +00:00

fmt.Sprintf can be removed now?

`fmt.Sprintf` can be removed now?

👍 1

fyrchik marked this conversation as resolved

acid-ant force-pushed bugfix/709-log-interface from 1a1a739bd8 to 079fe2b4af

2023-10-02 10:28:20 +00:00

Compare

dstepanov-yadro approved these changes 2023-10-02 11:26:43 +00:00

fyrchik commented

2023-10-02 11:27:16 +00:00

I don't see how it is related, but does 1.21 tests run locally for you? They fail on CI with some "mIssing package" error.

acid-ant commented

2023-10-02 11:33:29 +00:00

I don't see how it is related, but does 1.21 tests run locally for you? They fail on CI with some "mIssing package" error.

I am also surprised by this issue, it prompted me to put 1.21 at last, but everything is build and run fine locally.

> I don't see how it is related, but does 1.21 tests run locally for you? They fail on CI with some "mIssing package" error. I am also surprised by this issue, it prompted me to put 1.21 at last, but everything is build and run fine locally.

fyrchik merged commit 627b302745 into master

2023-10-02 13:31:11 +00:00

~~dstepanov-yadro referenced this pull request 2023-11-28 14:05:37 +00:00~~

Fix tree service sync #829

Sign in to join this conversation.

No reviewers