TrueCloudLab
/
frostfs-s3-gw
16
2
Fork 14
Code Issues 19 Pull Requests 4 Actions Packages Releases 6 Activity

[#172] Convert handler config to interface #206

Merged
alexvanin merged 1 commits from mbiryukova/frostfs-s3-gw:feature/convert_handler_config_to_interface into master 2023-10-04 11:01:28 +00:00
Conversation 1 Commits 1 Files Changed 12
mbiryukova commented 2023-09-11 07:42:48 +00:00
Collaborator

Closes #172

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Closes #172 Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova self-assigned this 2023-09-11 07:42:48 +00:00
mbiryukova force-pushed feature/convert_handler_config_to_interface from 2f890d4433 to c11a040618 2023-09-11 07:44:00 +00:00 Compare
mbiryukova requested review from storage-services-committers 2023-09-11 07:52:38 +00:00
mbiryukova requested review from storage-services-developers 2023-09-11 07:52:38 +00:00
pogpp approved these changes 2023-09-11 08:20:43 +00:00
r.loginov approved these changes 2023-09-13 11:50:45 +00:00
alexvanin commented 2023-09-18 12:50:43 +00:00
Owner

Let's merge it after #207

Let's merge it after #207
mbiryukova force-pushed feature/convert_handler_config_to_interface from c11a040618 to a2d1b7f980 2023-09-19 10:54:46 +00:00 Compare
dkirillov reviewed 2023-09-20 13:27:43 +00:00
cmd/s3-gw/app.go Outdated
@ -672,0 +713,4 @@
a.settings.resolveZoneList = a.cfg.GetStringSlice(cfgResolveBucketAllow)
a.settings.isResolveListAllow = len(a.settings.resolveZoneList) > 0
if !a.settings.isResolveListAllow {
dkirillov commented 2023-09-20 13:27:43 +00:00
Collaborator

It seems we can init all these fields in newAppSettings

It seems we can init all these fields in `newAppSettings`
dkirillov marked this conversation as resolved
dkirillov approved these changes 2023-09-20 13:28:39 +00:00
mbiryukova force-pushed feature/convert_handler_config_to_interface from a2d1b7f980 to 889d0a02f8 2023-09-21 09:04:07 +00:00 Compare
dkirillov approved these changes 2023-09-21 12:08:39 +00:00
alexvanin merged commit b8c93ed391 into master 2023-10-04 11:01:28 +00:00
alexvanin deleted branch feature/convert_handler_config_to_interface 2023-10-04 11:01:29 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
pogpp
r.loginov
dkirillov
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
mbiryukova
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#206
There is no content yet.
Delete Branch "mbiryukova/frostfs-s3-gw:feature/convert_handler_config_to_interface"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?