[#383] Fix request type determination #383

mbiryukova · 2024-05-06T10:23:48Z

mbiryukova commented

2024-05-06 10:23:48 +00:00

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>

mbiryukova self-assigned this 2024-05-06 10:23:48 +00:00

mbiryukova requested review from storage-services-committers 2024-05-06 10:29:23 +00:00

mbiryukova requested review from storage-services-developers 2024-05-06 10:29:23 +00:00

mbiryukova force-pushed bugfix/determine_req_type_0.29 from 9649387d89 to db924cc56e

2024-05-06 11:33:50 +00:00

Compare

dkirillov approved these changes 2024-05-06 14:39:15 +00:00

mbiryukova force-pushed bugfix/determine_req_type_0.29 from db924cc56e to 9879f593c8

2024-05-06 18:28:01 +00:00

Compare

dkirillov approved these changes 2024-05-07 06:46:29 +00:00

r.loginov approved these changes 2024-05-07 11:14:24 +00:00

alexvanin reviewed 2024-05-07 11:45:52 +00:00

api/middleware/policy.go Outdated

					
				@ -192,3 +192,3 @@

					}

					if ind := strings.IndexByte(bktObj, '/'); ind != -1 {

					if ind := strings.IndexByte(bktObj, '/'); ind != -1 && bktObj[ind+1:] != "" {

alexvanin commented

2024-05-07 11:45:51 +00:00

Why can't we just bktObj := strings.Trim(r.URL.Path, "/")?

Why can't we just `bktObj := strings.Trim(r.URL.Path, "/")`?

alexvanin commented

2024-05-07 11:53:43 +00:00

object may have '/' at the end, so we can't trim it.

alexvanin marked this conversation as resolved

alexvanin approved these changes 2024-05-07 11:53:52 +00:00

mbiryukova force-pushed bugfix/determine_req_type_0.29 from 9879f593c8 to c0f959ece7

2024-05-07 12:22:40 +00:00

Compare

alexvanin merged commit c0f959ece7 into support/v0.29

2024-05-07 12:33:53 +00:00

alexvanin deleted branch bugfix/determine_req_type_0.29

2024-05-07 12:33:53 +00:00

alexvanin referenced this pull request from a commit

2024-05-07 12:33:54 +00:00

[#383] Fix request type determination

alexvanin added this to the v0.29.0 milestone 2024-05-27 10:08:15 +00:00

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

4 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#383