TrueCloudLab
/
frostfs-s3-gw
16
2
Fork 14
Code Issues 19 Pull Requests 4 Actions Packages Releases 6 Activity

[#383] Fix request type determination #383

Merged
alexvanin merged 1 commits from mbiryukova/frostfs-s3-gw:bugfix/determine_req_type_0.29 into support/v0.29 2024-05-07 12:33:53 +00:00
Conversation 0 Commits 1 Files Changed 2
mbiryukova commented 2024-05-06 10:23:48 +00:00
Collaborator

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova self-assigned this 2024-05-06 10:23:48 +00:00
mbiryukova added 1 commit 2024-05-06 10:23:51 +00:00
/ DCO (pull_request) Successful in 1m46s Details
/ Vulncheck (pull_request) Failing after 1m57s Details
/ Builds (1.20) (pull_request) Successful in 2m44s Details
/ Builds (1.21) (pull_request) Successful in 1m33s Details
/ Lint (pull_request) Successful in 4m0s Details
/ Tests (1.20) (pull_request) Successful in 3m10s Details
/ Tests (1.21) (pull_request) Successful in 2m20s Details
9649387d89 [#383] Fix request type determination 
Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova requested review from storage-services-committers 2024-05-06 10:29:23 +00:00
mbiryukova requested review from storage-services-developers 2024-05-06 10:29:23 +00:00
mbiryukova force-pushed bugfix/determine_req_type_0.29 from 9649387d89 to db924cc56e 2024-05-06 11:33:50 +00:00 Compare
dkirillov approved these changes 2024-05-06 14:39:15 +00:00
mbiryukova force-pushed bugfix/determine_req_type_0.29 from db924cc56e to 9879f593c8 2024-05-06 18:28:01 +00:00 Compare
dkirillov approved these changes 2024-05-07 06:46:29 +00:00
r.loginov approved these changes 2024-05-07 11:14:24 +00:00
alexvanin reviewed 2024-05-07 11:45:52 +00:00
api/middleware/policy.go Outdated
@ -192,3 +192,3 @@
}
if ind := strings.IndexByte(bktObj, '/'); ind != -1 {
if ind := strings.IndexByte(bktObj, '/'); ind != -1 && bktObj[ind+1:] != "" {
alexvanin commented 2024-05-07 11:45:51 +00:00
Owner

Why can't we just bktObj := strings.Trim(r.URL.Path, "/")?

Why can't we just `bktObj := strings.Trim(r.URL.Path, "/")`?
alexvanin commented 2024-05-07 11:53:43 +00:00
Owner

object may have '/' at the end, so we can't trim it.

object may have '/' at the end, so we can't trim it.
alexvanin marked this conversation as resolved
alexvanin approved these changes 2024-05-07 11:53:52 +00:00
mbiryukova force-pushed bugfix/determine_req_type_0.29 from 9879f593c8 to c0f959ece7 2024-05-07 12:22:40 +00:00 Compare
alexvanin merged commit c0f959ece7 into support/v0.29 2024-05-07 12:33:53 +00:00
alexvanin deleted branch bugfix/determine_req_type_0.29 2024-05-07 12:33:53 +00:00
alexvanin added this to the v0.29.0 milestone 2024-05-27 10:08:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
r.loginov
alexvanin
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.29.0
Assignees
Clear assignees
No Assignees
mbiryukova
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#383
There is no content yet.
Delete Branch "mbiryukova/frostfs-s3-gw:bugfix/determine_req_type_0.29"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?