[#396] Add user to response #396

pogpp · 2024-05-27T14:42:28Z

pogpp commented

2024-05-27 14:42:28 +00:00

Signed-off-by: Pavel Pogodaev p.pogodaev@yadro.com

Signed-off-by: Pavel Pogodaev <p.pogodaev@yadro.com>

pogpp force-pushed feature/add_logs_to_request from cf7dd8f23f to be089b50a7

2024-05-27 14:43:24 +00:00

Compare

pogpp changed title from ~~[#] Add user to response~~ to [#396] Add user to response

2024-05-27 14:44:21 +00:00

dkirillov reviewed 2024-05-28 06:21:43 +00:00

api/middleware/response.go Outdated

					
				@ -329,2 +329,4 @@

								fields = append(fields, zap.String("object", reqInfo.ObjectName))

							}

							if reqInfo.User != "" {

								fields = append(fields, zap.String("user", reqInfo.User))

dkirillov commented

2024-05-28 06:21:43 +00:00

Do we need the same when request ends with error?

pogpp commented

2024-05-28 11:53:10 +00:00

Do we need the same when request ends with error?

Agree - added

> Do we need the same when request ends with error? Agree - added

dkirillov commented

2024-05-29 06:59:30 +00:00

I meant just log user in case of request failed (somewhere here) rather than include user info into error response.

I meant just log user in case of request failed (somewhere [here](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/9787b295427034396ed2ead8d0c1687a25beb4ec/api/handler/util.go#L39)) rather than include user info into error response.

👍 2

pogpp commented

2024-05-29 12:30:14 +00:00

done

dkirillov marked this conversation as resolved

pogpp force-pushed feature/add_logs_to_request from be089b50a7 to ee38f259bc

2024-05-28 11:52:42 +00:00

Compare

alexvanin requested review from storage-services-committers 2024-05-29 11:50:53 +00:00

alexvanin requested review from storage-services-developers 2024-05-29 11:50:53 +00:00

alexvanin added this to the v0.30.0 milestone 2024-05-29 11:51:03 +00:00

pogpp force-pushed feature/add_logs_to_request from ee38f259bc to cbed408670