TrueCloudLab
/
frostfs-s3-gw
16
2
Fork 14
Code Issues 19 Pull Requests 5 Actions Packages Releases 7 Activity

[#396] Add user to response #396

Merged
alexvanin merged 1 commits from pogpp/frostfs-s3-gw:feature/add_logs_to_request into master 2024-06-04 09:37:56 +00:00
Conversation 0 Commits 1 Files Changed 2
pogpp commented 2024-05-27 14:42:28 +00:00
Collaborator

Signed-off-by: Pavel Pogodaev p.pogodaev@yadro.com

Signed-off-by: Pavel Pogodaev <p.pogodaev@yadro.com>
pogpp added 1 commit 2024-05-27 14:42:31 +00:00
/ Vulncheck (pull_request) Successful in 1m22s Details
/ DCO (pull_request) Failing after 2m3s Details
/ Builds (1.20) (pull_request) Successful in 3m24s Details
/ Builds (1.21) (pull_request) Successful in 2m14s Details
/ Lint (pull_request) Successful in 4m41s Details
/ Tests (1.20) (pull_request) Successful in 3m25s Details
/ Tests (1.21) (pull_request) Successful in 3m11s Details
cf7dd8f23f [#] Add user to response 
Signed-off-by: Pavel Pogodaev <p.pogodaev@yadro.com>
pogpp force-pushed feature/add_logs_to_request from cf7dd8f23f to be089b50a7 2024-05-27 14:43:24 +00:00 Compare
pogpp changed title from [#] Add user to response to [#396] Add user to response 2024-05-27 14:44:21 +00:00
dkirillov reviewed 2024-05-28 06:21:43 +00:00
api/middleware/response.go Outdated
@ -329,2 +329,4 @@
fields = append(fields, zap.String("object", reqInfo.ObjectName))
}
if reqInfo.User != "" {
fields = append(fields, zap.String("user", reqInfo.User))
dkirillov commented 2024-05-28 06:21:43 +00:00
Collaborator

Do we need the same when request ends with error?

Do we need the same when request ends with error?
pogpp commented 2024-05-28 11:53:10 +00:00
Poster
Collaborator

Do we need the same when request ends with error?

Agree - added

> Do we need the same when request ends with error? Agree - added
dkirillov commented 2024-05-29 06:59:30 +00:00
Collaborator

I meant just log user in case of request failed (somewhere here) rather than include user info into error response.

I meant just log user in case of request failed (somewhere [here](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/9787b295427034396ed2ead8d0c1687a25beb4ec/api/handler/util.go#L39)) rather than include user info into error response.
👍 2
pogpp commented 2024-05-29 12:30:14 +00:00
Poster
Collaborator

done

done
dkirillov marked this conversation as resolved
pogpp force-pushed feature/add_logs_to_request from be089b50a7 to ee38f259bc 2024-05-28 11:52:42 +00:00 Compare
alexvanin requested review from storage-services-committers 2024-05-29 11:50:53 +00:00
alexvanin requested review from storage-services-developers 2024-05-29 11:50:53 +00:00
alexvanin added this to the v0.30.0 milestone 2024-05-29 11:51:03 +00:00
pogpp force-pushed feature/add_logs_to_request from ee38f259bc to cbed408670 2024-05-29 12:29:51 +00:00 Compare
dkirillov approved these changes 2024-05-29 12:53:58 +00:00
alexvanin approved these changes 2024-06-04 09:37:51 +00:00
alexvanin merged commit b5fae316cf into master 2024-06-04 09:37:56 +00:00
alexvanin deleted branch feature/add_logs_to_request 2024-06-04 09:37:57 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.30.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#396
There is no content yet.
Delete Branch "pogpp/frostfs-s3-gw:feature/add_logs_to_request"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?