TrueCloudLab/frostfs-s3-gw
14
2
Fork 17
Code Issues 22 Pull requests 6 Projects Releases 15 Packages Activity Actions

[#259] Support contract based policies #276

Merged
alexvanin merged 1 commit from dkirillov/frostfs-s3-gw:feature/259-support_policy_from_contract into master 2023-12-13 14:34:39 +00:00
Conversation 0 Commits 1 Files changed 18 +428 -43
dkirillov commented 2023-12-05 09:13:33 +00:00
Member
Copy link

close #259

close #259
dkirillov self-assigned this 2023-12-05 09:13:33 +00:00
dkirillov force-pushed feature/259-support_policy_from_contract from 9dbb08ae22 to 9d44314d74 2023-12-05 09:15:25 +00:00 Compare
dkirillov force-pushed feature/259-support_policy_from_contract from 9d44314d74 to ce76a9d570 2023-12-05 09:22:19 +00:00 Compare
dkirillov force-pushed feature/259-support_policy_from_contract from ce76a9d570 to a3f004d79a 2023-12-06 13:45:00 +00:00 Compare
dkirillov force-pushed feature/259-support_policy_from_contract from a3f004d79a to 5c797d4b91 2023-12-07 07:42:58 +00:00 Compare
dkirillov changed title from WIP: [#259] Support contract based policies to [#259] Support contract based policies 2023-12-07 07:43:18 +00:00
dkirillov force-pushed feature/259-support_policy_from_contract from 5c797d4b91 to 8aa9793416 2023-12-07 07:53:52 +00:00 Compare
dkirillov requested review from storage-services-committers 2023-12-07 07:54:58 +00:00
dkirillov requested review from storage-services-developers 2023-12-07 07:54:58 +00:00
pogpp approved these changes 2023-12-07 09:26:33 +00:00
dkirillov force-pushed feature/259-support_policy_from_contract from 8aa9793416 to cb1a7287d1 2023-12-08 07:50:13 +00:00 Compare
mbiryukova reviewed 2023-12-08 15:22:15 +00:00
api/cache/policy.go Outdated
@ -0,0 +12,4 @@
)
// MorphPolicyCache provides lru cache for listing policies stored in policy contract.
// This cache contains mapping nice names to object addresses.
mbiryukova commented 2023-12-08 15:19:44 +00:00
Member
Copy link

Seems it's not for this cache

Seems it's not for this cache
mbiryukova marked this conversation as resolved
cmd/s3-gw/app_settings.go Outdated
@ -689,6 +695,10 @@ func newSettings() *viper.Viper {
v.SetDefault(cfgFrostfsIDContract, "frostfsid.frostfs")
v.SetDefault(cfgFrostfsIDEnabled, true)
// frostfsid
mbiryukova commented 2023-12-08 15:21:45 +00:00
Member
Copy link

policy

policy
mbiryukova marked this conversation as resolved
internal/frostfs/policy/contract/contract.go Outdated
@ -0,0 +28,4 @@
// Contract is hash of contract or its name in NNS.
Contract string
// Key is used to interact with frostfsid contract.
mbiryukova commented 2023-12-08 15:22:11 +00:00
Member
Copy link

policy contract

policy contract
mbiryukova marked this conversation as resolved
dkirillov force-pushed feature/259-support_policy_from_contract from cb1a7287d1 to 9272f4e108 2023-12-11 07:02:01 +00:00 Compare
mbiryukova approved these changes 2023-12-12 10:14:48 +00:00
alexvanin approved these changes 2023-12-13 14:30:47 +00:00
alexvanin merged commit 9272f4e108 into master 2023-12-13 14:34:39 +00:00
alexvanin deleted branch feature/259-support_policy_from_contract 2023-12-13 14:34:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
pogpp
mbiryukova
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#276
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:feature/259-support_policy_from_contract"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?