feature/261-update_put-bucket-policy_to_use_contract #279
No reviewers
TrueCloudLab/storage-services-developers
Labels
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-s3-gw#279
Loading…
Reference in New Issue
There is no content yet.
Delete Branch "dkirillov/frostfs-s3-gw:feature/261-update_put-bucket-policy_to_use_contract"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
close #261
7e1c3ddbfb
tod12a45f4e9
WIP: feature/261-update_put-bucket-policy_to_use_contractto feature/261-update_put-bucket-policy_to_use_contractd12a45f4e9
to4f5d95aa8e
@ -1134,73 +1186,6 @@ func resourceInfoFromName(name, bucketName string) resourceInfo {
return resInfo
}
func astToPolicy(ast *ast) *bucketPolicy {
I will miss this code 😃
@ -53,3 +52,3 @@
reqInfo := GetReqInfo(r.Context())
target := engine.NewRequestTargetWithNamespace(settings.ResolveNamespaceAlias(reqInfo.Namespace))
st, found, err := storage.IsAllowed(policy.S3ChainName, target, req)
st, found, err := storage.IsAllowed("s3", target, req)
chain.S3
?Sure
@ -8,3 +13,4 @@
"go.uber.org/zap"
)
const S3ChainName chain.Name = "s3"
Isn't it completely replaced by
chain.S3
?@ -23,0 +42,4 @@
var _ handler.APE = (*Storage)(nil)
func NewStorage(cfg StorageConfig) *Storage {
// todo use thread safe inmemory
Maybe link to the issue in policy engine repo?
I wanted to implement thread same in memory storage in s3-gw repo but forgot
But let's create issue for policy engine TrueCloudLab/policy-engine#35
4f5d95aa8e
to38c5503a02
dkirillov referenced this pull request2023-12-19 09:49:12 +00:00