TrueCloudLab/frostfs-s3-gw
18
3
Fork 20
Code Issues 29 Pull requests 7 Projects Releases 23 Packages 1 Activity Actions

feature/261-update_put-bucket-policy_to_use_contract #279

Merged
alexvanin merged 3 commits from dkirillov/frostfs-s3-gw:feature/261-update_put-bucket-policy_to_use_contract into master 2024-09-04 19:51:12 +00:00
Conversation 0 Commits 3 Files changed 19 +604 -292
dkirillov commented 2023-12-11 09:58:16 +00:00
Member
Copy link

close #261

close #261
dkirillov self-assigned this 2023-12-11 09:58:16 +00:00
dkirillov added 1 commit 2023-12-11 09:58:19 +00:00
[#259] Support contract based policies
All checks were successful
/ DCO (pull_request) Successful in 1m21s
Details
/ Vulncheck (pull_request) Successful in 1m41s
Details
/ Builds (1.20) (pull_request) Successful in 2m19s
Details
/ Builds (1.21) (pull_request) Successful in 2m1s
Details
/ Lint (pull_request) Successful in 3m20s
Details
/ Tests (1.20) (pull_request) Successful in 2m14s
Details
/ Tests (1.21) (pull_request) Successful in 2m10s
Details
9272f4e108 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov force-pushed feature/261-update_put-bucket-policy_to_use_contract from 7e1c3ddbfb to d12a45f4e9 2023-12-13 15:00:00 +00:00 Compare
dkirillov changed title from WIP: feature/261-update_put-bucket-policy_to_use_contract to feature/261-update_put-bucket-policy_to_use_contract 2023-12-13 15:00:51 +00:00
dkirillov requested review from storage-services-committers 2023-12-13 15:00:59 +00:00
dkirillov requested review from storage-services-developers 2023-12-14 06:38:21 +00:00
dkirillov force-pushed feature/261-update_put-bucket-policy_to_use_contract from d12a45f4e9 to 4f5d95aa8e 2023-12-14 14:52:26 +00:00 Compare
alexvanin reviewed 2023-12-18 10:29:23 +00:00
api/handler/acl.go Outdated
@ -1134,73 +1186,6 @@ func resourceInfoFromName(name, bucketName string) resourceInfo {
return resInfo
}
func astToPolicy(ast *ast) *bucketPolicy {
alexvanin commented 2023-12-18 10:29:04 +00:00
Owner
Copy link

I will miss this code 😃

I will miss this code 😃
😆 1
api/middleware/policy.go Outdated
@ -53,3 +52,3 @@
reqInfo := GetReqInfo(r.Context())
target := engine.NewRequestTargetWithNamespace(settings.ResolveNamespaceAlias(reqInfo.Namespace))
st, found, err := storage.IsAllowed(policy.S3ChainName, target, req)
st, found, err := storage.IsAllowed("s3", target, req)
alexvanin commented 2023-12-18 10:27:40 +00:00
Owner
Copy link

chain.S3?

`chain.S3`?
dkirillov commented 2023-12-18 12:38:36 +00:00
Author
Member
Copy link

Sure

Sure
internal/frostfs/policy/storage.go
@ -8,3 +13,4 @@
"go.uber.org/zap"
)
const S3ChainName chain.Name = "s3"
alexvanin commented 2023-12-18 10:24:42 +00:00
Owner
Copy link

Isn't it completely replaced by chain.S3?

Isn't it completely replaced by `chain.S3`?
internal/frostfs/policy/storage.go Outdated
@ -23,0 +42,4 @@
var _ handler.APE = (*Storage)(nil)
func NewStorage(cfg StorageConfig) *Storage {
// todo use thread safe inmemory
alexvanin commented 2023-12-18 10:25:16 +00:00
Owner
Copy link

Maybe link to the issue in policy engine repo?

Maybe link to the issue in policy engine repo?
dkirillov commented 2023-12-18 12:43:27 +00:00
Author
Member
Copy link

I wanted to implement thread same in memory storage in s3-gw repo but forgot

I wanted to implement thread same in memory storage in s3-gw repo but forgot
dkirillov commented 2023-12-18 12:44:36 +00:00
Author
Member
Copy link

But let's create issue for policy engine TrueCloudLab/policy-engine#35

But let's create issue for policy engine https://git.frostfs.info/TrueCloudLab/policy-engine/issues/35
dkirillov force-pushed feature/261-update_put-bucket-policy_to_use_contract from 4f5d95aa8e to 38c5503a02 2023-12-18 12:50:12 +00:00 Compare
alexvanin approved these changes 2023-12-20 07:41:12 +00:00
alexvanin merged commit 38c5503a02 into master 2023-12-20 07:41:24 +00:00
alexvanin deleted branch feature/261-update_put-bucket-policy_to_use_contract 2023-12-20 07:41:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#279
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:feature/261-update_put-bucket-policy_to_use_contract"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?