TrueCloudLab/frostfs-s3-gw
14
2
Fork 17
Code Issues 21 Pull requests 4 Projects Releases 15 Packages Activity Actions

[#280] Add put requests to duration metric #285

Merged
alexvanin merged 1 commit from mbiryukova/frostfs-s3-gw:bugfix/put_reqs_to_duration_metric into master 2023-12-25 08:56:33 +00:00
Conversation 0 Commits 1 Files changed 1 +2 -4
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
api/middleware/metrics.go
View file

@ -95,10 +95,8 @@ func stats(f http.HandlerFunc, resolveCID cidResolveFunc, appMetrics *metrics.Ap
} }
} }
if r.Method == http.MethodGet {
// Increment the prometheus http request response histogram with appropriate label // Increment the prometheus http request response histogram with appropriate label
dkirillov marked this conversation as resolved Outdated
dkirillov commented 2023-12-21 09:05:52 +00:00
Outdated
Review
Copy link

Maybe we can drop condition at all?
cc @alexvanin

Maybe we can drop condition at all? cc @alexvanin
alexvanin commented 2023-12-22 13:27:25 +00:00
Outdated
Review
Copy link

Let's do it. Don't see much value in it.

Let's do it. Don't see much value in it.
appMetrics.Statistic().RequestDurationsUpdate(reqInfo.API, durationSecs) appMetrics.Statistic().RequestDurationsUpdate(reqInfo.API, durationSecs)
}
appMetrics.Statistic().TotalInputBytesAdd(in.countBytes) appMetrics.Statistic().TotalInputBytesAdd(in.countBytes)
appMetrics.Statistic().TotalOutputBytesAdd(out.countBytes) appMetrics.Statistic().TotalOutputBytesAdd(out.countBytes)