bugfix/split_tree #437
No reviewers
TrueCloudLab/storage-services-developers
Labels
No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-s3-gw#437
Loading…
Reference in a new issue
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:bugfix/split_tree"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Continuation of #430
[#437] tree: Support removing old split system nodes
It's need to fit user expectation on deleting CORs for example.
Previously after removing cors (that was uploaded in split manner)
we can still get some data (from other node)
because deletion worked only for latest node version.
1dd43924cc
to36361ee535
I suggest to update link in commits to
[#437]
. Also, please, describe solving issues in the PR description.36361ee535
to47b8202c86
47b8202c86
to689f7ee818
bugfix/split_treeto bugfix/split_treeLooks good. As for me, I would rather keep tree cleaning stuff from
tree.go
in a separate function with proper comment on why we have to do that.Let me know what you think about it.
Also I would like some feedback other whether it makes code simpler to read or not
/cc @mbiryukova, @r.loginov
We can define function like this
And use it like this