TrueCloudLab/frostfs-sdk-csharp
16
0
Fork 3
Code Issues 5 Pull requests Projects Releases Packages Activity Actions

[#23] Client: Refactoring to optimize memory usage #28

Merged
PavelGrossSpb merged 2 commits from PavelGrossSpb/frostfs-sdk-csharp:misc/refactoring into master 2024-09-12 12:54:25 +00:00
Conversation 2 Commits 2 Files changed 141 +1722 -896
PavelGrossSpb commented 2024-09-11 07:59:45 +00:00
Member
Copy link

Signed-off-by: Pavel Gross p.gross@yando.com

Signed-off-by: Pavel Gross <p.gross@yando.com>
PavelGrossSpb added 1 commit 2024-09-11 07:59:45 +00:00
[#23] Client: Refactoring to optimize memory usage
All checks were successful
DCO / DCO (pull_request) Successful in 33s
Details
6562aa27a5 
Signed-off-by: Pavel Gross <p.gross@yando.com>
PavelGrossSpb requested review from orikik 2024-09-11 08:01:09 +00:00
PavelGrossSpb requested review from dstepanov-yadro 2024-09-11 08:02:14 +00:00
dstepanov-yadro commented 2024-09-11 08:35:34 +00:00
Member
Copy link

What optimizations are added in this PR? I see 141 changes in one commit, with most of the changes being name changes.

What optimizations are added in this PR? I see 141 changes in one commit, with most of the changes being name changes.
dstepanov-yadro reviewed 2024-09-11 09:03:24 +00:00
src/FrostFS.SDK.ClientV2/Models/Enums/FrostFsObjectMatchType.cs Outdated
@ -0,0 +1,10 @@
namespace FrostFS.SDK;
public enum FrostFsObjectMatchType
dstepanov-yadro commented 2024-09-11 08:42:40 +00:00
Member
Copy link

Why this change? Full type name was FrostFS.SDK.ObjectMatchType, but now it is FrostFS.SDK.FrostFsObjectMatchType. Does FrostFS.SDK namespace has other ObjectMatchType except FrostFs one?

Why this change? Full type name was `FrostFS.SDK.ObjectMatchType`, but now it is `FrostFS.SDK.FrostFsObjectMatchType`. Does `FrostFS.SDK` namespace has other `ObjectMatchType` except `FrostFs` one?
PavelGrossSpb commented 2024-09-12 09:02:12 +00:00
Author
Member
Copy link

Fixed to FrostFsMatchType. We have MatchType from GRPC namespaces. All users types starts with FrostFs to avoid full naming.

Fixed to FrostFsMatchType. We have MatchType from GRPC namespaces. All users types starts with FrostFs to avoid full naming.
dstepanov-yadro marked this conversation as resolved
src/FrostFS.SDK.ClientV2/Parameters/PrmObjectHeadGet.cs
@ -1,13 +1,11 @@
using FrostFS.SDK.ModelsV2;
namespace FrostFS.SDK.ClientV2;
dstepanov-yadro commented 2024-09-11 08:53:22 +00:00
Member
Copy link

As far as I remember, C# code style requires that namespace must correspond directory structure.

As far as I remember, C# code style requires that namespace must correspond directory structure.
PavelGrossSpb commented 2024-09-11 11:12:18 +00:00
Author
Member
Copy link

Yes, it one of the suggestion. Requirements are defined by vendor. As for me, folder hierarchy is useful for structuring, but dozens of using - are not, especially for external users. Do we have such a requirement?

Yes, it one of the suggestion. Requirements are defined by vendor. As for me, folder hierarchy is useful for structuring, but dozens of using - are not, especially for external users. Do we have such a requirement?
dstepanov-yadro commented 2024-09-11 11:28:25 +00:00
Member
Copy link

No

No
dstepanov-yadro marked this conversation as resolved
PavelGrossSpb added 1 commit 2024-09-12 08:56:43 +00:00
[#23] Client: Refactoring to optimize memory usage
All checks were successful
DCO / DCO (pull_request) Successful in 53s
Details
704ce41173 
Signed-off-by: Pavel Gross <p.gross@yando.com>
PavelGrossSpb commented 2024-09-12 09:06:09 +00:00
Author
Member
Copy link

The main optimization is creating GRPC object once. In case of multiple usage, only one coventation is applied.

The main optimization is creating GRPC object once. In case of multiple usage, only one coventation is applied.
orikik approved these changes 2024-09-12 11:53:29 +00:00
PavelGrossSpb merged commit 704ce41173 into master 2024-09-12 12:54:25 +00:00
PavelGrossSpb deleted branch misc/refactoring 2024-09-12 12:54:25 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
orikik
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-csharp#28
No description provided.
Delete branch "PavelGrossSpb/frostfs-sdk-csharp:misc/refactoring"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?