TrueCloudLab
/
frostfs-sdk-go
28
0
Fork 18
Code Issues 27 Pull Requests 2 Actions Releases Activity

[#76] netmap: Add new keyword NOT #78

Merged
acid-ant merged 1 commits from aarifullin/frostfs-sdk-go:feature/26-add_new_keywords into master 2023-06-05 08:57:10 +00:00
Conversation 4 Commits 1 Files Changed 17
aarifullin commented 2023-05-24 09:55:32 +00:00
Collaborator
  • Add the rule for NOT operation to the policy parser grammar
  • Regenerate query parse
  • Implement NOT in filter
  • Add unit-tests

Signed-off-by: Airat Arifullin a.arifullin@yadro.com

* Add the rule for NOT operation to the policy parser grammar * Regenerate query parse * Implement NOT in filter * Add unit-tests Signed-off-by: Airat Arifullin a.arifullin@yadro.com
aarifullin added the
enhancement
 label 2023-05-24 09:55:32 +00:00
aarifullin requested review from acid-ant 2023-05-24 09:56:29 +00:00
aarifullin requested review from storage-core-developers 2023-05-24 09:56:29 +00:00
aarifullin requested review from storage-core-committers 2023-05-24 09:56:29 +00:00
aarifullin commented 2023-05-24 10:00:06 +00:00
Poster
Collaborator

@fyrchik FYI, @acid-ant doesn't mind if it's me who implements NOT

@fyrchik FYI, @acid-ant doesn't mind if it's me who implements `NOT`
aarifullin commented 2023-05-24 10:17:47 +00:00
Poster
Collaborator

Sorry, didn't pay attention on that.
I have not introduce UnaryOperation and used old way

UPD: UnaryFilterExpr has been introduced and works finely

Sorry, didn't pay attention on [that](https://git.frostfs.info/TrueCloudLab/frostfs-api/issues/26#issuecomment-10156). I have not introduce `UnaryOperation` and used old way UPD: `UnaryFilterExpr` has been introduced and works finely
aarifullin force-pushed feature/26-add_new_keywords from c1710f1bd0 to d9f0085688 2023-05-24 12:58:48 +00:00 Compare
aarifullin force-pushed feature/26-add_new_keywords from d9f0085688 to eca10e00fc 2023-05-24 13:04:17 +00:00 Compare
aarifullin force-pushed feature/26-add_new_keywords from eca10e00fc to ac61aa07d6 2023-05-24 13:04:59 +00:00 Compare
aarifullin reviewed 2023-05-26 09:38:14 +00:00
ale64bit approved these changes 2023-05-29 07:19:05 +00:00
netmap/parser/Query.g4 Outdated
@ -24,2 +27,3 @@
filterExpr:
F1 = filterExpr Op = AND_OP F2 = filterExpr
unaryFilterExpr
ale64bit commented 2023-05-29 07:17:58 +00:00
Collaborator

not sure why not to just inline this expression, if it has only one production.

not sure why not to just inline this expression, if it has only one production.
👍 1
ale64bit marked this conversation as resolved
aarifullin force-pushed feature/26-add_new_keywords from ac61aa07d6 to f7ddc48105 2023-06-01 14:43:11 +00:00 Compare
aarifullin requested review from ale64bit 2023-06-01 14:44:40 +00:00
ale64bit reviewed 2023-06-02 07:17:39 +00:00
netmap/parser/query_visitor.go Outdated
@ -1,4 +1,4 @@
// Code generated from /work/netmap/parser/Query.g4 by ANTLR 4.13.0. DO NOT EDIT.
// Code generated from /home/aarifullin/ws/frostfs-sdk-go/netmap/parser/Query.g4 by ANTLR 4.13.0. DO NOT EDIT.
ale64bit commented 2023-06-02 07:17:39 +00:00
Collaborator

can we remove all the auto-generated files from the diff somehow? It's a bit weird also that they include user-specific paths after auto-generation.

can we remove all the auto-generated files from the diff somehow? It's a bit weird also that they include user-specific paths after auto-generation.
aarifullin commented 2023-06-02 11:52:55 +00:00
Poster
Collaborator

You mean - comments? I haven't noticed that but I agree this shouldn't be here

You mean - comments? I haven't noticed that but I agree this shouldn't be here
ale64bit commented 2023-06-02 11:54:38 +00:00
Collaborator

I mean just to remove the auto-generated files from PR diffs somehow, independently of what they contain. I don't know if it's possible.

I mean just to remove the auto-generated files from PR diffs somehow, independently of what they contain. I don't know if it's possible.
aarifullin commented 2023-06-02 11:56:54 +00:00
Poster
Collaborator

Oh, I don't think this is the good idea to ignore diffs in auto-generated files :( But I think that's fine to remove comments

Oh, I don't think this is the good idea to ignore diffs in auto-generated files :( But I think that's fine to remove comments
ale64bit marked this conversation as resolved
ale64bit approved these changes 2023-06-02 07:19:31 +00:00
ale64bit commented 2023-06-02 07:40:45 +00:00
Collaborator

Can we update the PR/commit description? It refers to #26, which is misleading since I guess it's not that issue (in this repo) and it says it adds keyword UNIQUE (which it doesn't).

Can we update the PR/commit description? It refers to #26, which is misleading since I guess it's not that issue (in this repo) and it says it adds keyword `UNIQUE` (which it doesn't).
aarifullin force-pushed feature/26-add_new_keywords from f7ddc48105 to de8530f98c 2023-06-02 11:57:50 +00:00 Compare
aarifullin changed title from [#26] netmap: Add new keywords NOT and UNIQUE to [#78] netmap: Add new keywords NOT and UNIQUE 2023-06-02 11:58:09 +00:00
aarifullin commented 2023-06-02 11:58:22 +00:00
Poster
Collaborator

Can we update the PR/commit description? It refers to #26, which is misleading since I guess it's not that issue (in this repo) and it says it adds keyword UNIQUE (which it doesn't).

Thank you. Fixed

> Can we update the PR/commit description? It refers to #26, which is misleading since I guess it's not that issue (in this repo) and it says it adds keyword `UNIQUE` (which it doesn't). Thank you. Fixed
aarifullin requested review from ale64bit 2023-06-02 11:58:27 +00:00
acid-ant approved these changes 2023-06-02 13:01:06 +00:00
ale64bit approved these changes 2023-06-02 13:36:32 +00:00
ale64bit changed title from [#78] netmap: Add new keywords NOT and UNIQUE to [#78] netmap: Add new keyword NOT 2023-06-02 13:39:17 +00:00
aarifullin force-pushed feature/26-add_new_keywords from de8530f98c to 4f48f6c9e0 2023-06-02 14:47:31 +00:00 Compare
aarifullin requested review from acid-ant 2023-06-02 14:47:36 +00:00
aarifullin requested review from ale64bit 2023-06-02 14:47:38 +00:00
ale64bit approved these changes 2023-06-05 08:01:17 +00:00
aarifullin changed title from [#78] netmap: Add new keyword NOT to [#76] netmap: Add new keyword NOT 2023-06-05 08:05:01 +00:00
acid-ant approved these changes 2023-06-05 08:56:02 +00:00
acid-ant merged commit 4f48f6c9e0 into master 2023-06-05 08:57:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
ale64bit
acid-ant
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers   
pool

Tasks related to client pool
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#78
There is no content yet.
Delete Branch "aarifullin/frostfs-sdk-go:feature/26-add_new_keywords"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?