Airat Arifullin aarifullin
  • Joined on 2023-03-16
aarifullin closed issue TrueCloudLab/frostfs-node#1389 2025-02-17 07:29:24 +00:00
ape-manager service should allow list APE chains with node wallet
aarifullin closed pull request TrueCloudLab/frostfs-node#1638 2025-02-17 07:28:38 +00:00
Make listing chains with generated wallet
aarifullin commented on pull request TrueCloudLab/frostfs-node#1638 2025-02-17 07:28:37 +00:00
Make listing chains with generated wallet

This PR won't be merged because it breaks privacy giving the free access to list container APE rules and an owner isn't able to restrict this action (if we consider a public network).

As I've…

aarifullin approved TrueCloudLab/frostfs-qos#4 2025-02-13 08:46:02 +00:00
limiting: Add Limiter

Excellent

aarifullin commented on pull request TrueCloudLab/frostfs-qos#4 2025-02-13 08:24:54 +00:00
limiting: Add Limiter

Leftovers?

aarifullin commented on pull request TrueCloudLab/frostfs-qos#4 2025-02-13 07:55:55 +00:00
limiting: Add Limiter

countDown -> countdown as it's one word :)

aarifullin commented on pull request TrueCloudLab/frostfs-node#1629 2025-02-10 17:13:11 +00:00
adm: Allow use any wallets

Please, could we use name RegularWallets instead of Simple?

aarifullin commented on pull request TrueCloudLab/frostfs-node#1629 2025-02-10 17:12:13 +00:00
adm: Allow use any wallets

May we have a situation when the actor should sign not only by alphabet wallets but also simple wallets (alphabet + simple)?

aarifullin commented on pull request TrueCloudLab/frostfs-qos#4 2025-02-07 16:16:14 +00:00
limiting: Add Limiter

This PR is absolutely OK with me. But, let's be honest, the PR is introducing rather a semaphore than a true limiter. It's just a naïve implementation of a rate-limiter. Here I suggest to discuss…

aarifullin commented on pull request TrueCloudLab/frostfs-qos#4 2025-02-07 15:23:30 +00:00
limiting: Add Limiter
sem, ok := lr.m[key]
	if !ok {
		return func() {}, nil
	}

Yeah, okay. Then nevermind

aarifullin commented on pull request TrueCloudLab/frostfs-qos#4 2025-02-07 15:19:48 +00:00
limiting: Add Limiter

It's enough to acquire semaphore by two concurrent goroutines and we're on panic :)