Airat Arifullin aarifullin
  • Joined on 2023-03-16
aarifullin commented on pull request TrueCloudLab/frostfs-node#1634 2025-02-04 15:13:37 +00:00
adm/frostfsid: Add 'set-kv'

You don't need to introduce the constant. You've already got disableFlag. So, feel free to use it in cmd.Flags().GetBool(disable) :)

aarifullin commented on pull request TrueCloudLab/frostfs-locode-db#21 2025-01-31 12:51:49 +00:00
Add missing locode details using overrides

Do we need to use once?

We don't, for sure. Fixed

aarifullin commented on pull request TrueCloudLab/frostfs-locode-db#21 2025-01-31 12:51:23 +00:00
Add missing locode details using overrides

Fixed

aarifullin pushed to fix/missing_locodes at aarifullin/frostfs-locode-db 2025-01-31 12:45:34 +00:00
f35b1c62e8 [#21] locode: Count ignored and added records to result locode db
f2113a9c02 [#21] locode: Introduce locode overriding
Compare 2 commits »
aarifullin commented on issue TrueCloudLab/frostfs-node#1624 2025-01-30 14:06:47 +00:00
Blobovniczas initialization won't return an explicit error

I think the problem is that b.iterateExistingDBPaths(egCtx, func(p string) (bool, error) uses errgroup's context. So when errgroup fails with an error, egCtx is canceled, but `iterateExisting…

aarifullin commented on issue TrueCloudLab/frostfs-node#1624 2025-01-30 13:25:39 +00:00
Blobovniczas initialization won't return an explicit error

I believe eg.Wait() should return exactly the first error it has got, no?

We'll check soon

aarifullin commented on pull request TrueCloudLab/frostfs-node#1621 2025-01-30 13:18:28 +00:00
Cancel tree sync on errors

I believe that was incorrect from the very beginning. TBH, I don't remember the task context in details. But glancing at mergeOperationStreams I conclude it has returned MaxUint64, probably,…

aarifullin opened issue TrueCloudLab/frostfs-node#1624 2025-01-30 12:50:26 +00:00
Blobovniczas initialization won't return an explicit error
aarifullin commented on pull request TrueCloudLab/frostfs-node#1621 2025-01-30 09:17:00 +00:00
Cancel tree sync on errors

If context is done, then we may get newHeight = math.MaxUint64 + 1 -> newHeight = 0 because applyOperationStream may not return an error

aarifullin approved TrueCloudLab/frostfs-sdk-go#327 2025-01-30 08:08:35 +00:00
rpc: Fix mem leak again

Perfect

aarifullin approved TrueCloudLab/frostfs-sdk-go#324 2025-01-29 14:01:56 +00:00
Fix mem leak
aarifullin approved TrueCloudLab/frostfs-qos#2 2025-01-24 14:50:25 +00:00
Tagging

👍

aarifullin commented on pull request TrueCloudLab/frostfs-qos#2 2025-01-24 14:49:53 +00:00
Tagging

My initial concern was about whether currentTagKey overrides currentTagKeyFromSomeOtherPackageWithTheSameIOTA. I checked it on my own: it's fine, context keeps two keys. So, nevermind!

aarifullin commented on pull request TrueCloudLab/frostfs-qos#2 2025-01-24 14:20:33 +00:00
Tagging

Using int/string as a key within Context may cause some problems. You should introduce:

aarifullin approved TrueCloudLab/frostfs-qos#1 2025-01-23 15:04:19 +00:00
mclock: Initial implementation

Excellent idea 👍