ale64bit
  • Joined on 2023-03-06
ale64bit pushed to fix/352-clarify-too-many-alpha-nodes at ale64bit/frostfs-node 2023-05-16 08:22:43 +00:00
7a9743272c [#352] Add explicit max number of alphabet nodes
079b28fa0f [#341] Register candidates in separate transactions
d4d921dcaf [#346] adm: fix race in wallet generation
429a87e83b [#39] ir: Use defer for wg.Done()
f604d6bbdc [#39] ir: Add optional profilers
Compare 8 commits »
ale64bit commented on pull request TrueCloudLab/frostfs-node#353 2023-05-16 08:19:51 +00:00
Simplify write-cache (SUPPORT)

are these supposed to be committed?

ale64bit commented on pull request TrueCloudLab/frostfs-node#348 2023-05-15 16:30:50 +00:00
Fix complex object deletion

I'm not sure what to do about it, but it would be nice to look at it some other time.

ale64bit commented on pull request TrueCloudLab/frostfs-node#349 2023-05-15 12:15:38 +00:00
[#341] Register candidates in separate transactions

It does fail with >=23, due to the second failure described in #295.

ale64bit commented on pull request TrueCloudLab/frostfs-node#348 2023-05-15 12:14:05 +00:00
Fix complex object deletion

why the check? the next loop won't do anything anyway.

ale64bit commented on pull request TrueCloudLab/frostfs-node#348 2023-05-15 12:14:05 +00:00
Fix complex object deletion

why the slicing ([:]) here? it's already a slice.

ale64bit commented on pull request TrueCloudLab/frostfs-node#348 2023-05-15 12:14:05 +00:00
Fix complex object deletion

this is unfortunate...isn't there another way? (same below)

ale64bit commented on pull request TrueCloudLab/frostfs-node#348 2023-05-15 12:14:05 +00:00
Fix complex object deletion

we have already some very similar functionality. Can we avoid the duping?

ale64bit created pull request TrueCloudLab/frostfs-node#349 2023-05-15 11:48:17 +00:00
[#341] Register candidates in separate transactions
ale64bit created branch fix/341-register-candidate-batching in ale64bit/frostfs-node 2023-05-15 11:46:58 +00:00
ale64bit pushed to fix/341-register-candidate-batching at ale64bit/frostfs-node 2023-05-15 11:46:58 +00:00
d803c225ab [#341] Register candidates in separate transactions
a6ee7a3087 [#324] Add replicator metrics
6055b18362 [#342] morph: Remove unused toStackParameter()
02c02974b3 [#309] locode: Parallelize DB generation
147ae8728a [#309] go.mod: Update paulmach/orb to v0.9.1
Compare 10 commits »
ale64bit pushed to feature/324-replicator-metrics at ale64bit/frostfs-node 2023-05-12 09:40:37 +00:00
9f24c8666f [#324] Add replicator metrics
ale64bit commented on pull request TrueCloudLab/frostfs-node#340 2023-05-12 09:08:28 +00:00
[#324] Add replicator metrics

As a nice correctness check, have you verified that scripts/metrics-exporter provides the metrics you added?

I wasn't aware of that script. But they do appear:

{"name":"frostfs_node_re…
ale64bit commented on pull request TrueCloudLab/frostfs-node#340 2023-05-12 09:08:02 +00:00
[#324] Add replicator metrics

done

ale64bit pushed to feature/324-replicator-metrics at ale64bit/frostfs-node 2023-05-12 09:07:51 +00:00
a4e10d943b [#324] Add replicator metrics
ale64bit created pull request TrueCloudLab/frostfs-node#340 2023-05-12 08:46:11 +00:00
[#324] Add replicator metrics
ale64bit created branch feature/324-replicator-metrics in ale64bit/frostfs-node 2023-05-12 08:45:03 +00:00