metrics.go
-> node.go
On Windows it won't even compile and this is WAI. We have many nix-specific dependencies all over the place (implicit and explicit ones).
Ofc it's not enforced, especially when having pointer fields. But I guess it's a combination of it being conventional and easier to look at the struct and its doc when calling New
, rather than…
I would prefer the positional arguments if they are required. They can be packed into a Options
struct if needed.
It seems relatively easy to build incorrect objects in other places as well,…
I'm not sure. Usually for debugging issues here it's either no logging (default) or all logs (the development logger). Maybe let's change it later if a concrete use case arises.
can we call it buildRequest
, asRequest
or simply request
instead? Maybe I'm biased, but this sounds more like "requesting a form" than "forming a request" :)