ale64bit
  • Joined on 2023-03-06
ale64bit commented on pull request TrueCloudLab/frostfs-node#173 2023-03-29 11:51:29 +00:00
[#139] test: Add test storage implementation

What's wrong with returning both arguments? Seems to me that way it's more clear what is returned and the cast/indexing is unnecessary (those assume a type and slice size).

ale64bit commented on pull request TrueCloudLab/frostfs-node#173 2023-03-29 11:50:04 +00:00
[#139] test: Add test storage implementation

done

ale64bit commented on pull request TrueCloudLab/frostfs-node#173 2023-03-29 11:49:54 +00:00
[#139] test: Add test storage implementation

done

ale64bit pushed to fix/139-unit_test_storage at ale64bit/frostfs-node 2023-03-29 11:49:30 +00:00
dd99c28fae [#139] test: Add test storage implementation
ale64bit commented on issue TrueCloudLab/xk6-frostfs#14 2023-03-29 10:54:58 +00:00
Add local targets

@fyrchik Could you clarify how much of S3 would you like to actually run in the local S3 scenario? I see the following possibilities:

  1. Use only the recently merged [NewTree](https://git.frostf
ale64bit approved TrueCloudLab/frostfs-node#182 2023-03-29 08:54:56 +00:00
[#180] node: Refactor panics in unit test

LGTM (after resolving the pending comment)

ale64bit commented on pull request TrueCloudLab/frostfs-node#173 2023-03-29 07:26:11 +00:00
[#139] test: Add test storage implementation

(force push only for fixing go.mod, go.sum conflicts)

ale64bit pushed to fix/139-unit_test_storage at ale64bit/frostfs-node 2023-03-29 07:25:14 +00:00
e5c5235357 [#139] test: Add test storage implementation
91717d4b98 [#176] morph: Resolve funlen linter
382ecae96a [#172] Use ContainersOf() for container list fetching
9e54646248 [#172] client/container: Support listing containers with containersOf
bf7d80f44b [#172] morph/client: Support iterators via neo-go session API
Compare 24 commits »
ale64bit commented on pull request TrueCloudLab/frostfs-node#182 2023-03-29 07:15:03 +00:00
[#180] node: Refactor panics in unit test

even if it's a test error, can we use a more meaningful message?

ale64bit suggested changes for TrueCloudLab/frostfs-node#182 2023-03-29 07:15:03 +00:00
[#180] node: Refactor panics in unit test
ale64bit commented on pull request TrueCloudLab/frostfs-s3-gw#62 2023-03-28 10:57:12 +00:00
[#59] tree: Make interface for tree service client

I would simply remove all Get* prefixes, but up to you.

ale64bit commented on pull request TrueCloudLab/frostfs-s3-gw#62 2023-03-28 10:57:12 +00:00
[#59] tree: Make interface for tree service client

even though it's an in-memory implementation, can we use some meaningful error messages?

ale64bit commented on pull request TrueCloudLab/frostfs-s3-gw#62 2023-03-28 10:44:45 +00:00
[#59] tree: Make interface for tree service client

can we move the grpc options as arguments?

ale64bit commented on pull request TrueCloudLab/frostfs-node#173 2023-03-28 10:38:07 +00:00
[#139] test: Add test storage implementation

It seems that it was easier to use gomockery :-)

I agree :))

ale64bit commented on pull request TrueCloudLab/frostfs-node#168 2023-03-27 11:15:26 +00:00
frostfs-node refactorings

IMHO, neither the context should be stored in a struct (ctx docs discourage this explicitly) nor the state/functioning of the engine instance should depend on…

ale64bit commented on issue TrueCloudLab/xk6-frostfs#46 2023-03-27 07:52:16 +00:00
Need some utility to read and show content from registry file

would it be simpler to just dump the registry in a format that is readable+explorable and performant already? (e.g. sqlite or whatever)

ale64bit commented on pull request TrueCloudLab/frostfs-node#30 2023-03-24 09:48:13 +00:00
[#1248] node: Do not update cache twice

I see. But what I had in mind is that if you are calling LoadOrStore and there happened to be a value already (locked or otherwise), the mutex you just created and locked is never actually…