Denis Kirillov dkirillov
  • Joined on 2023-03-06
dkirillov commented on pull request TrueCloudLab/frostfs-contract#119 2024-10-25 13:55:57 +00:00
Integrate frostfsid into NNS

Should this be

dkirillov commented on pull request TrueCloudLab/frostfs-contract#119 2024-10-25 13:52:25 +00:00
Integrate frostfsid into NNS

I suggest to rename this function to GetSubjectKV

dkirillov commented on pull request TrueCloudLab/frostfs-sdk-go#290 2024-10-25 13:46:36 +00:00
[#185] Control timeout of tree service operations

We should add default value for this param in fillDefaultInitParams

dkirillov commented on pull request TrueCloudLab/frostfs-sdk-go#290 2024-10-25 13:44:33 +00:00
[#185] Control timeout of tree service operations

I meant:

diff --git a/pool/tree/pool.go b/pool/tree/pool.go
index be2cb2d..3d89146 100644
--- a/pool/tree/pool.go
+++ b/pool/tree/pool.go
@@ -362,10 +362,8 @@ func (p *Pool)…
dkirillov approved TrueCloudLab/frostfs-node#1443 2024-10-25 13:06:51 +00:00
tree: Use delete verb instead put for Remove

LGTM, but can we add some tests?

dkirillov pushed to feature/158-add_cors at dkirillov/frostfs-http-gw 2024-10-25 06:42:38 +00:00
46c63edd67 [#158] Support cors
901b8ff95b [#158] Fix integration test compilation error
8dc5272965 [#158] Rework app settings
Compare 3 commits »
dkirillov pushed to feature/158-add_cors at dkirillov/frostfs-http-gw 2024-10-24 15:02:20 +00:00
a9aeea1c70 [#158] Support cors
dkirillov created pull request TrueCloudLab/frostfs-http-gw#159 2024-10-24 14:28:30 +00:00
feature/158-add_cors
dkirillov created branch feature/158-add_cors in dkirillov/frostfs-http-gw 2024-10-24 14:28:04 +00:00
dkirillov pushed to feature/158-add_cors at dkirillov/frostfs-http-gw 2024-10-24 14:28:04 +00:00
239397f86c [#158] Support cors
eb62ace99a [#158] Fix integration test compilation error
b9132c8f37 [#158] Rework app settings
70846fdaec [#157] Support the continuous use of interceptors
Compare 4 commits »
dkirillov commented on pull request TrueCloudLab/frostfs-node#1443 2024-10-24 12:46:03 +00:00
tree: Use delete verb instead put for Remove

I suppose it's ok to use just acl.OpObjectDelete here (in tree service). But for the same check in object service it seems we need add object type property. Otherwise, if put tombstone request…

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#521 2024-10-24 06:38:08 +00:00
Multinet dialer support

I don't have a strong opinion

dkirillov commented on pull request TrueCloudLab/frostfs-sdk-go#290 2024-10-23 14:48:43 +00:00
[#185] Control timeout of tree service operations

Why don't invoke this function inside p.requestWithRetry?

dkirillov opened issue TrueCloudLab/frostfs-http-gw#158 2024-10-23 13:15:44 +00:00
Support CORs
dkirillov pushed to poc/hls at dkirillov/frostfs-http-gw 2024-10-23 12:55:55 +00:00
31922f4d54 [#XX] poc
dkirillov pushed to poc/custom_aws_creds at dkirillov/frostfs-s3-gw 2024-10-23 12:01:44 +00:00
3cf27d281d [#509] Support fallback address when getting box
3c7cb82553 [#509] Init resolvers before first resolving
57b7e83380 [#509] Save isCustom flag into accessbox
6a90f4e624 [#509] Update docs
cb3753f286 [#509] Add tests for custom credentials
Compare 8 commits »
dkirillov pushed to poc/custom_aws_creds at dkirillov/frostfs-s3-gw 2024-10-23 12:01:00 +00:00
97b9206230 [#509] Support fallback address when getting box
c554e07834 [#509] Init resolvers before first resolving
10c68f7d15 [#509] Save isCustom flag into accessbox
05e3478bde [#509] Update docs
27f7f3f8ce [#509] Add tests for custom credentials
Compare 10 commits »
dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#521 2024-10-23 11:29:36 +00:00
Multinet dialer support

It seems we also need add some todo

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#521 2024-10-23 11:29:36 +00:00
Multinet dialer support

Currently this is unused. Do we really need add this right now?