Denis Kirillov dkirillov

0 followers · 0 following

• Joined on 2023-03-06
• • 
  • 

Repositories

18

Projects Packages Code Public activity Starred repositories

1

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-08 14:30:47 +00:00

[#469] List multipart uploads streaming

Why do we pass marker and uploadID?

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-08 14:30:47 +00:00

[#469] List multipart uploads streaming

Why do this if differ from the similar from object listing?

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-08 14:30:47 +00:00

[#469] List multipart uploads streaming

We cannot use ctx from current request. It will be canceled after first request be finished

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-08 14:30:47 +00:00

[#469] List multipart uploads streaming

It seems now we can skip checking prefix inside uploadInfoFromMultipart and result always be non nil

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-08 14:30:47 +00:00

[#469] List multipart uploads streaming

Why don't just for uploadsCount < p.MaxUploads { ?

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-08 14:30:47 +00:00

[#469] List multipart uploads streaming

This method isn't used

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-08 14:30:47 +00:00

[#469] List multipart uploads streaming

Why did we move this to data package?

dkirillov approved TrueCloudLab/frostfs-http-gw#153 2024-11-08 11:03:06 +00:00

[#151] Index page for FrostFS containers

Overall LGTM (see minor comments)

dkirillov commented on pull request TrueCloudLab/frostfs-http-gw#153 2024-11-08 11:01:12 +00:00

[#151] Index page for FrostFS containers

Please don't use var when we initialize struct:

dkirillov commented on pull request TrueCloudLab/frostfs-http-gw#153 2024-11-08 10:55:41 +00:00

[#151] Index page for FrostFS containers

Please place this field right below dialerSource

dkirillov deleted branch feature/correct_test_groups from dkirillov/s3-tests-parser 2024-11-08 10:50:17 +00:00

dkirillov pushed to master at TrueCloudLab/s3-tests-parser 2024-11-08 10:50:16 +00:00

f35917a01d [#2] Add .forgejo files

a7ca907332 [#2] Correct test groups

e54a9c9e6c [#2] Support verbose flag and include

Compare 3 commits »

dkirillov merged pull request TrueCloudLab/s3-tests-parser#2 2024-11-08 10:50:15 +00:00

feature/correct_test_groups

dkirillov pushed to feature/add_s3-gw_tls at dkirillov/frostfs-aio 2024-11-08 10:39:50 +00:00

6e4817101d [#52] Support TLS for s3-gw

dkirillov approved TrueCloudLab/frostfs-aio#51 2024-11-08 10:34:46 +00:00

[#48] Add S3 Lifecycler

LGTM

dkirillov commented on pull request TrueCloudLab/frostfs-aio#51 2024-11-08 10:26:28 +00:00

[#48] Add S3 Lifecycler

Should we also enable tags?

dkirillov approved TrueCloudLab/frostfs-dev-env#87 2024-11-08 10:17:50 +00:00

[#85] Add s3 lifecycler

LGTM

dkirillov pushed to feature/add_s3-gw_tls at dkirillov/frostfs-aio 2024-11-08 09:38:12 +00:00

d3954811f8 [#52] Support TLS for s3-gw

dkirillov pushed to feature/add_s3-gw_tls at dkirillov/frostfs-aio 2024-11-08 09:08:03 +00:00

be23b14564 [#52] Support TLS for s3-gw

dkirillov created pull request TrueCloudLab/frostfs-aio#52 2024-11-08 09:07:46 +00:00

[#XX] Support TLS for s3-gw