Denis Kirillov

dkirillov approved TrueCloudLab/frostfs-http-gw#160

2024-10-31 13:26:46 +00:00

Multinet dialer support

LGTM

dkirillov commented on pull request TrueCloudLab/frostfs-dev-env#87

2024-10-31 06:43:25 +00:00

[#85] Add s3 lifecycler

Let's enable metrics.

dkirillov commented on pull request TrueCloudLab/frostfs-dev-env#87

2024-10-31 06:42:10 +00:00

[#85] Add s3 lifecycler

Actually, I'm not sure if we need .s3_lifecycler.env. Can we drop this file at all?

dkirillov commented on pull request TrueCloudLab/frostfs-dev-env#87

2024-10-31 06:41:09 +00:00

[#85] Add s3 lifecycler

credential section still doesn't contains wallet frostfs-dev-env/wallets/wallet.json

dkirillov commented on pull request TrueCloudLab/frostfs-contract#119

2024-10-31 06:33:32 +00:00

Integrate frostfsid into NNS

I'm not sure. It seems you fixed wrong line

dkirillov approved TrueCloudLab/frostfs-s3-gw#526

2024-10-31 06:30:24 +00:00

[#505] authmate: Add flag for headers in generate-presigned-url cmd

LGTM

dkirillov approved TrueCloudLab/frostfs-s3-gw#528

2024-10-31 06:27:15 +00:00

[#528] Check owner ID before deleting bucket

dkirillov commented on pull request TrueCloudLab/frostfs-contract#119

2024-10-30 11:41:55 +00:00

Integrate frostfsid into NNS

My comment was just about avoiding panic when result will contain just one element and we will try to access the second (frostfsIDAddress[1])

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#528

2024-10-30 11:31:54 +00:00

[#528] Check owner ID before deleting bucket

We already have checkOwner function

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#526

2024-10-30 11:24:08 +00:00

[#505] authmate: Add flag for headers in generate-presigned-url cmd

It's better to use more general flag like header to be able to pass any headers we want

dkirillov commented on pull request TrueCloudLab/frostfs-dev-env#87

2024-10-29 14:00:35 +00:00

[#85] Add s3 lifecycler

Please, add close #85 to PR description

dkirillov commented on pull request TrueCloudLab/frostfs-dev-env#87

2024-10-29 13:59:29 +00:00

[#85] Add s3 lifecycler

Please keep here only variable that use ${LOCAL_DOMAIN}. Other params move to cfg/conig.yml and omit them if they have default values

dkirillov commented on pull request TrueCloudLab/frostfs-dev-env#87

2024-10-29 13:58:11 +00:00

[#85] Add s3 lifecycler

We can omit this param

dkirillov commented on pull request TrueCloudLab/frostfs-dev-env#87

2024-10-29 13:57:06 +00:00

[#85] Add s3 lifecycler

These variable can be omitted or moved to cfg/config.yml

dkirillov commented on pull request TrueCloudLab/frostfs-dev-env#87

2024-10-29 13:56:43 +00:00

[#85] Add s3 lifecycler

Lifecycler doesn't have such variable

dkirillov commented on pull request TrueCloudLab/frostfs-dev-env#87

2024-10-29 13:55:22 +00:00

[#85] Add s3 lifecycler

We don't need this file

dkirillov commented on pull request TrueCloudLab/frostfs-dev-env#87

2024-10-29 13:55:13 +00:00

[#85] Add s3 lifecycler

We don't need this file

dkirillov commented on pull request TrueCloudLab/frostfs-dev-env#87

2024-10-29 13:53:30 +00:00

[#85] Add s3 lifecycler

We should add credential section into config (this section should contain wallet from frostfs-dev-env/wallets/wallet.json) https://git.frostfs.info/TrueCloudLab/frostfs-s3-lifecycler/src/branch…

dkirillov commented on pull request TrueCloudLab/frostfs-dev-env#87

2024-10-29 13:52:14 +00:00

[#85] Add s3 lifecycler

These params (max_clients_count, max_clients_deadline, resolve_order) aren't applicable to s3-lifecycler

dkirillov commented on pull request TrueCloudLab/frostfs-dev-env#87

2024-10-29 13:51:31 +00:00

[#85] Add s3 lifecycler

This param should be in frostfs section see https://git.frostfs.info/TrueCloudLab/frostfs-s3-lifecycler/src/branch/master/docs/configuration.md