Roman Loginov r.loginov
  • Joined on 2023-08-03
r.loginov commented on pull request TrueCloudLab/frostfs-s3-gw#566 2024-12-03 13:03:42 +00:00
[#562] Support TLS termination header for SSE-C

question: At the moment, I have not found any tests for the formEncryptionParamsBase function. Should I add them?

r.loginov commented on pull request TrueCloudLab/frostfs-s3-gw#566 2024-12-03 13:03:42 +00:00
[#562] Support TLS termination header for SSE-C

I'm not completely sure that you should just output a warning here, maybe you should return an error here after all.

r.loginov created pull request TrueCloudLab/frostfs-s3-gw#566 2024-12-03 12:52:37 +00:00
[#562] Support TLS termination header for SSE-C
56025dab9f [#562] Support TLS termination header for SSE-C
r.loginov created branch feature/562-support_tls_termination in r.loginov/frostfs-s3-gw 2024-12-03 12:38:05 +00:00
e1579f16c0 [#562] Support TLS termination header for SSE-C
r.loginov commented on pull request TrueCloudLab/frostfs-http-gw#173 2024-12-02 10:54:34 +00:00
[#151] Fix getting s3 object with the FrostFS OID key

nitpick: Perhaps you should write the acronym in the same case: foundOid -> foundOID.

35a592438b [#498] Update frostfs-observability version
ad7742eecb [#498] middleware: Add spans to detail the trace
8e7cc4c954 [#498] frostfs: Add spans to detail the trace
993e2bb114 [#498] tree: Add spans to detail the trace
8a1f4f8eab [#498] layer: Add spans to detail the trace
Compare 7 commits »
r.loginov commented on pull request TrueCloudLab/frostfs-s3-gw#564 2024-12-02 09:12:24 +00:00
feature/498-make_query_tracing_more_detailed

Yes, you are right, because there may be an online appeal to the storage.

r.loginov commented on pull request TrueCloudLab/frostfs-s3-gw#564 2024-12-02 09:11:30 +00:00
feature/498-make_query_tracing_more_detailed

In middleware.The auth context is eventually modified and added to http.Request, which is why…

58e7f3d583 [#163] Support JSON bearer token
ef933df556 [#498] Update frostfs-observability version
3c9659cbde [#498] middleware: Add spans to detail the trace
e757f48be9 [#498] frostfs: Add spans to detail the trace
6951fd5a59 [#498] tree: Add spans to detail the trace
98ee0fa901 [#498] layer: Add spans to detail the trace
Compare 8 commits »
r.loginov commented on pull request TrueCloudLab/frostfs-http-gw#171 2024-11-29 07:51:10 +00:00
feature/145-make_query_tracing_more_detailed

Because h.by Native Address is called in two handlers: DownloadByAddressOrBucketName and `HeadByAddressOrBucketName'. If you start the span right there, then you will need to give it a name…

r.loginov created pull request TrueCloudLab/frostfs-http-gw#172 2024-11-29 06:56:54 +00:00
[#163] Support JSON bearer token
4478d638ad [#163] Support JSON bearer token
3a0f78ed9f [#163] Support JSON bearer token
2cc11d3427 [#145] Update frostfs-observability version